From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312Ab2D3Hr1 (ORCPT ); Mon, 30 Apr 2012 03:47:27 -0400 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:38947 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254Ab2D3Hr0 (ORCPT ); Mon, 30 Apr 2012 03:47:26 -0400 Date: Mon, 30 Apr 2012 09:47:17 +0200 From: Borislav Petkov To: Mauro Carvalho Chehab Cc: Joe Perches , Borislav Petkov , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers Message-ID: <20120430074717.GB8182@aftab.osrc.amd.com> References: <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> <4F9D4F6E.4070106@redhat.com> <4F9D5A2E.2030506@redhat.com> <4F9D6A39.6040209@redhat.com> <1335717794.12022.19.camel@joe2Laptop> <4F9D7CB8.4000903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F9D7CB8.4000903@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 29, 2012 at 02:39:04PM -0300, Mauro Carvalho Chehab wrote: > Em 29-04-2012 13:43, Joe Perches escreveu: > > On Sun, 2012-04-29 at 13:20 -0300, Mauro Carvalho Chehab wrote: > >> The script below is even better. After that, only 113 occurrences of __func__ > >> is now found at drivers/edac, and some of them are not related to debugf[1-9], > >> so they shouldn't be cover on a patch like that. > >> I'll do some manual cleanup on it. > > > > Hi Mauro. > > > > Another thing you could do would be to > > separate the level from the multiple macros, > > use a single macro, and convert the uses. > > > > #define debugf(level, fmt, ...) > > and change the uses to > > debugf([0-n], "some format", args...) > > > > I believe that's the more predominate > > kernel style for debugging macros with > > a tested level or mask. > > Agreed. > > > Perhaps also add !CONFIG_EDAC_DEBUG > > format/args checking to the debug statements. > > Most/all debug-only stuff are already checking for CONFIG_EDAC_DEBUG. > There are a few static debug-only data/functions that aren't testing for > it, but the compiler should remove the dead code anyway, so this shouldn't > cause any harm. > > > Lastly, indenting the messages 2 tabs isn't > > really useful, one or two spaces is probably > > enough. > > agreed. > > > > > I did this a bit ago so it may not apply > > after your changes: > > Believe or not, it applied without troubles ;) > > I've added at the end of my experimental series, at: > > > git://git.infradead.org/users/mchehab/edac.git experimental > > be careful if you use this branch, as I'm rebasing it every time I need > to change something on this series. > > I'm keeping a non-rebased version, with one branch per review, at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git > > The current review is at hw_events_v17. Patches were already pushed there. > they should be there after the usual kernel.org master/mirror replication > delay. Now wait a minute, you guys are so trigger-happy to apply humongous, cleanup patches but let me ask this: can anyone of you really test those changes with each driver? Do you have all the hardware that those patches touch? I know, I know, it builds fine and it looks correct but subtle bugs tend to sneak in in exactly such situations. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551