All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: David Howells <dhowells@redhat.com>
Subject: [patch V2 01/31] frv: Use correct size for task_struct allocation
Date: Thu, 03 May 2012 09:02:47 -0000	[thread overview]
Message-ID: <20120503085033.898475542@linutronix.de> (raw)
In-Reply-To: 20120503083859.991965503@linutronix.de

[-- Attachment #1: frv-use-correct-size-for-task-struct-allocation.patch --]
[-- Type: text/plain, Size: 1114 bytes --]

alloc_task_struct_node() allocates THREAD_SIZE and maintains some
weird refcount in the allocated memory. This never blew up as
task_struct size on 32bit machines was always less than THREAD_SIZE

Allocate just sizeof(struct task_struct) and get rid of the magic
refcounting.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: David Howells <dhowells@redhat.com>

---
 arch/frv/kernel/process.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Index: tip/arch/frv/kernel/process.c
===================================================================
--- tip.orig/arch/frv/kernel/process.c
+++ tip/arch/frv/kernel/process.c
@@ -45,17 +45,12 @@ EXPORT_SYMBOL(pm_power_off);
 
 struct task_struct *alloc_task_struct_node(int node)
 {
-	struct task_struct *p = kmalloc_node(THREAD_SIZE, GFP_KERNEL, node);
-
-	if (p)
-		atomic_set((atomic_t *)(p+1), 1);
-	return p;
+	return kmalloc_node(sizeof(task_struct), GFP_KERNEL, node);
 }
 
 void free_task_struct(struct task_struct *p)
 {
-	if (atomic_dec_and_test((atomic_t *)(p+1)))
-		kfree(p);
+	kfree(p);
 }
 
 static void core_sleep_idle(void)



  reply	other threads:[~2012-05-03  9:02 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  9:02 [patch V2 00/31] init_task: Use a generic init_task variant Thomas Gleixner
2012-05-03  9:02 ` Thomas Gleixner [this message]
2012-05-05 18:46   ` [tip:smp/hotplug] frv: Use correct size for task_struct allocation tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 02/31] frv: Use core allocator for task_struct Thomas Gleixner
2012-05-05 18:47   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 03/31] task_allocator: Use config switches instead of magic defines Thomas Gleixner
2012-05-03  9:02 ` [patch V2 04/31] init_task: Create generic init_task instance Thomas Gleixner
2012-05-05 18:49   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 05/31] alpha: Use generic init_task Thomas Gleixner
2012-05-05 18:50   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 06/31] arm: " Thomas Gleixner
2012-05-05 18:51   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 07/31] avr32: " Thomas Gleixner
2012-05-05 18:51   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 08/31] blackfin: " Thomas Gleixner
2012-05-05 18:52   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 10/31] cris: " Thomas Gleixner
2012-05-05 18:54   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 09/31] cx6: " Thomas Gleixner
2012-05-03 13:45   ` Mark Salter
2012-05-03 15:25     ` Thomas Gleixner
2012-05-05 18:53   ` [tip:smp/hotplug] c6x: " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 11/31] frv: " Thomas Gleixner
2012-05-05 18:55   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 12/31] h8300: " Thomas Gleixner
2012-05-05 18:56   ` [tip:smp/hotplug] h8300-use-generic-init_task tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 14/31] m32r: Use generic init_task Thomas Gleixner
2012-05-05 18:57   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 13/31] hexagon: Use generic idle_task Thomas Gleixner
2012-05-05 18:56   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 15/31] m68k: Use generic init_task Thomas Gleixner
2012-05-05 18:58   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 16/31] microblaze: " Thomas Gleixner
2012-05-05 18:59   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 17/31] mips: " Thomas Gleixner
2012-05-05 19:00   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 19/31] openrisc: " Thomas Gleixner
2012-05-05 19:01   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-08  9:37   ` [patch V2 19/31] " Jonas Bonn
2012-05-03  9:02 ` [patch V2 18/31] mn10300: " Thomas Gleixner
2012-05-05 19:01   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 21/31] powerpc: " Thomas Gleixner
2012-05-05 19:03   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 20/31] parisc: " Thomas Gleixner
2012-05-05 19:02   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 22/31] s390: " Thomas Gleixner
2012-05-03 10:00   ` Heiko Carstens
2012-05-05 19:04   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 23/31] score: " Thomas Gleixner
2012-05-05 19:05   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 26/31] tile: " Thomas Gleixner
2012-05-05 19:07   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 24/31] sh: " Thomas Gleixner
2012-05-05 19:06   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:02 ` [patch V2 25/31] sparc: " Thomas Gleixner
2012-05-05 19:06   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:03 ` [patch V2 27/31] um: " Thomas Gleixner
2012-05-05 19:09   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:03 ` [patch V2 28/31] unicore32: " Thomas Gleixner
2012-05-05 19:08   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:03 ` [patch V2 29/31] x86: " Thomas Gleixner
2012-05-05 19:10   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:03 ` [patch V2 30/31] xtensa: " Thomas Gleixner
2012-05-05 19:11   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-03  9:03 ` [patch V2 31/31] init_task: Replace CONFIG_HAVE_GENERIC_INIT_TASK Thomas Gleixner
2012-05-05 19:11   ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-04 17:28 ` [patch V2 03/31] task_allocator: Use config switches instead of magic defines David Howells
2012-05-05 10:54   ` Thomas Gleixner
2012-05-04 17:30 ` [patch V2 02/31] frv: Use core allocator for task_struct David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503085033.898475542@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.