From: Richard Cochran <richardcochran@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH RFC V1 4/5] timekeeping: Offer an interface to manipulate leap seconds.
Date: Sat, 5 May 2012 12:17:35 +0200 [thread overview]
Message-ID: <20120505101735.GB8294@netboy.at.omicron.at> (raw)
In-Reply-To: <4F9B26D3.1030100@linaro.org>
On Fri, Apr 27, 2012 at 04:08:03PM -0700, John Stultz wrote:
> On 04/27/2012 01:12 AM, Richard Cochran wrote:
>
> >+#ifdef CONFIG_DELETE_LEAP_SECONDS
> >+ /* Remembers whether to insert or to delete. */
> >+ int insert_leapsecond;
> >+#endif
>
> I'm not a big fan of this additional config option. The maintenance
> burden for the extra condition is probably not worth the code size
> trade-off. Or it needs way more justification.
Out of curiosity, I looked at ntp-4.2.6p5 to see if they really
support deleting leap seconds or not. Even though the code appears to
try and support them, I spotted a few bugs. There is a hard coded
assumption that the TAI offset is increasing.
This is just the reason why I suggest not supporting deletions (or
only conditionally for nit pickers). You can code it up, but it will
be in vain, since the code will never be tested or used in practice.
Code that is never executed is a true mainenance burden by definition.
Richard
next prev parent reply other threads:[~2012-05-05 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 8:12 [PATCH RFC V1 0/5] Rationalize time keeping Richard Cochran
2012-04-27 8:12 ` [PATCH RFC V1 1/5] Add functions to convert continuous timescales to UTC Richard Cochran
2012-04-27 8:12 ` [PATCH RFC V1 2/5] ntp: Fix a stale comment and a few stray newlines Richard Cochran
2012-04-27 22:25 ` John Stultz
2012-04-27 8:12 ` [PATCH RFC V1 3/5] timekeeping: Fix a few minor newline issues Richard Cochran
2012-04-27 22:25 ` John Stultz
2012-04-27 8:12 ` [PATCH RFC V1 4/5] timekeeping: Offer an interface to manipulate leap seconds Richard Cochran
2012-04-27 23:08 ` John Stultz
2012-04-28 8:47 ` Richard Cochran
2012-05-05 10:17 ` Richard Cochran [this message]
2012-05-07 17:36 ` John Stultz
2012-04-27 8:12 ` [PATCH RFC V1 5/5] timekeeping: Use a continuous timescale to tell time Richard Cochran
2012-05-28 16:49 ` Richard Cochran
2012-04-27 22:49 ` [PATCH RFC V1 0/5] Rationalize time keeping John Stultz
2012-04-28 8:04 ` Richard Cochran
2012-04-30 20:56 ` John Stultz
2012-05-01 7:17 ` Richard Cochran
2012-05-01 8:01 ` John Stultz
2012-05-01 18:43 ` Richard Cochran
2012-05-03 7:02 ` Richard Cochran
2012-05-03 15:48 ` John Stultz
2012-05-03 18:21 ` Richard Cochran
2012-05-03 18:44 ` John Stultz
2012-05-03 19:28 ` Richard Cochran
2012-05-03 19:42 ` John Stultz
2012-05-03 19:57 ` John Stultz
2012-05-05 7:34 ` Richard Cochran
2012-05-05 19:25 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120505101735.GB8294@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.