From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Always update RPS interrupts thresholds along with frequency Date: Tue, 22 May 2012 20:56:55 +0200 Message-ID: <20120522185654.GE4629@phenom.ffwll.local> References: <1335599799-10377-1-git-send-email-chris@chris-wilson.co.uk> <20120428191830.4cb7d464@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 14BE0A02C8 for ; Tue, 22 May 2012 11:55:36 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so5073204wgb.12 for ; Tue, 22 May 2012 11:55:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120428191830.4cb7d464@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 28, 2012 at 07:18:30PM -0700, Ben Widawsky wrote: > On Sat, 28 Apr 2012 08:56:39 +0100 > Chris Wilson wrote: > > > In order to avoid missed down-interrupts when coming out of RC6, it is > > advised that we always reset the down-threshold upon a PM event. This > > is due to that the PM unit goes through a little dance when coming > > out of RC6, it first brings the GPU up at the lowest frequency then a > > short time later it restores the thresholds. During that interval, the > > down-interval may expire and the interrupt be suppressed. > > > > Now aware of the dance taking place within the GPU when coming out of > > RC6, one wonders what other writes need to be queued in the fifo > > buffer in order to be properly sequenced; setting the RP state > > appears to be one. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44006 > > Signed-off-by: Chris Wilson > > I tried really hard to review this, but it was too much. The code > definitely is cleaner as a result, so this is: > Acked-by: Ben Widawsky Picked up for -fixes with Jesse's irc r-b added, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48