All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrey Rahmatullin <wrar@wrar.name>
Cc: ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	linux-pm@lists.linux-foundation.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [RFT][PATCH 1/4] ACPI / PM: Make acpi_pm_device_sleep_state() follow the specification
Date: Sat, 26 May 2012 23:19:33 +0200	[thread overview]
Message-ID: <201205262319.33464.rjw@sisk.pl> (raw)
In-Reply-To: <201205262316.30096.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

The comparison between the system sleep state being entered
and the lowest system sleep state the given device may wake up
from in acpi_pm_device_sleep_state() is reversed, because the
specification (ACPI 5.0) says that for wakeup to work:

"The sleeping state being entered must be less than or equal to the
 power state declared in element 1 of the _PRW object."

In other words, the state returned by _PRW is the deepest
(lowest-power) system sleep state the device is capable of waking up
the system from.

Moreover, acpi_pm_device_sleep_state() also should check if the
wakeup capability is supported through ACPI, because in principle it
may be done via native PCIe PME, for example, in which case _SxW
should not be evaluated.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/acpi/sleep.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/acpi/sleep.c
===================================================================
--- linux.orig/drivers/acpi/sleep.c
+++ linux/drivers/acpi/sleep.c
@@ -732,8 +732,8 @@ int acpi_pm_device_sleep_state(struct de
 	 * can wake the system.  _S0W may be valid, too.
 	 */
 	if (acpi_target_sleep_state == ACPI_STATE_S0 ||
-	    (device_may_wakeup(dev) &&
-	     adev->wakeup.sleep_state <= acpi_target_sleep_state)) {
+	    (device_may_wakeup(dev) && adev->wakeup.flags.valid &&
+	     adev->wakeup.sleep_state >= acpi_target_sleep_state)) {
 		acpi_status status;
 
 		acpi_method[3] = 'W';

  reply	other threads:[~2012-05-26 21:19 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 16:55 ehci_hcd related S3 lockup on ASUS laptops, again Andrey Rahmatullin
     [not found] ` <20120411165531.GA3717-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-11 17:06   ` Steven Rostedt
     [not found]     ` <1334164013.23924.271.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-11 17:25       ` Alan Stern
     [not found]         ` <Pine.LNX.4.44L0.1204111324100.1351-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-11 19:12           ` [linux-pm] " Alan Stern
     [not found]             ` <Pine.LNX.4.44L0.1204111429510.1351-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-11 20:43               ` Steven Rostedt
     [not found]                 ` <1334177035.23924.299.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-11 21:13                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1204111703180.1351-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-11 21:19                       ` Steven Rostedt
2012-04-11 22:09                     ` Andrey Rahmatullin
2012-04-12  1:22                       ` Steven Rostedt
     [not found]                         ` <1334193773.23924.316.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-12 14:28                           ` [linux-pm] " Alan Stern
2012-04-12 15:37                             ` Andrey Rahmatullin
     [not found]                               ` <20120412153750.GA12852-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-12 16:09                                 ` [linux-pm] " Alan Stern
     [not found]                                   ` <Pine.LNX.4.44L0.1204121203530.1496-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-12 16:49                                     ` Andrey Rahmatullin
2012-04-12 16:52                                       ` Steven Rostedt
2012-04-12 16:58                                         ` Andrey Rahmatullin
2012-04-12 16:33                             ` Steven Rostedt
2012-04-12 17:06                               ` Alan Stern
2012-04-12 17:14                                 ` Steven Rostedt
2012-04-12 17:18                                   ` Andrey Rahmatullin
2012-04-12 17:48                                   ` Alan Stern
2012-04-12 18:17                                     ` Steven Rostedt
2012-04-12 18:25                                       ` Steven Rostedt
2012-04-12 19:11                                         ` Alan Stern
     [not found]                                           ` <Pine.LNX.4.44L0.1204121504550.1496-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-12 19:24                                             ` [linux-pm] " Andrey Rahmatullin
2012-04-12 19:35                                             ` Steven Rostedt
2012-04-12 20:02                                               ` Alan Stern
2012-04-12 20:09                                                 ` Alan Stern
2012-04-12 20:21                                                   ` Andrey Rahmatullin
     [not found]                                                     ` <20120412202132.GH12852-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-12 20:33                                                       ` [linux-pm] " Steven Rostedt
     [not found]                                                         ` <1334262826.23924.351.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-13  1:09                                                           ` Alan Stern
2012-04-13  1:03                                                     ` Alan Stern
2012-04-12 20:30                                                 ` Andrey Rahmatullin
2012-04-13  1:09                                                   ` Alan Stern
     [not found]                                                     ` <Pine.LNX.4.44L0.1204122103230.10558-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-13 14:10                                                       ` [linux-pm] " Alan Stern
     [not found]                                                         ` <Pine.LNX.4.44L0.1204131008010.1185-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-13 15:29                                                           ` Steven Rostedt
     [not found]                                                             ` <1334330949.23924.360.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-13 15:32                                                               ` Steven Rostedt
     [not found]                                                                 ` <1334331148.23924.361.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-13 15:35                                                                   ` Steven Rostedt
2012-04-13 15:42                                                               ` Alan Stern
2012-04-13 21:04                                                             ` Alan Stern
2012-04-13 22:43                                                           ` [linux-pm] " Andrey Rahmatullin
2012-04-16 20:07                                                             ` Alan Stern
2012-04-16 21:19                                                               ` Andrey Rahmatullin
2012-04-17 15:11                                                                 ` Alan Stern
2012-04-17 16:25                                                                   ` Andrey Rahmatullin
2012-04-17 16:58                                                                     ` Alan Stern
     [not found]                                                                       ` <Pine.LNX.4.44L0.1204171251330.1364-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-17 17:51                                                                         ` [linux-pm] " Andrey Rahmatullin
     [not found]                                                                           ` <20120417175122.GM11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-17 18:26                                                                             ` Alan Stern
     [not found]                                                                               ` <Pine.LNX.4.44L0.1204171423310.1163-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-17 18:51                                                                                 ` Andrey Rahmatullin
     [not found]                                                                                   ` <20120417185149.GO11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-17 19:20                                                                                     ` Alan Stern
     [not found]                                                                                       ` <Pine.LNX.4.44L0.1204171513230.1163-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-17 19:52                                                                                         ` Andrey Rahmatullin
     [not found]                                                                                           ` <20120417195218.GP11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-18 14:51                                                                                             ` Alan Stern
     [not found]                                                                                               ` <Pine.LNX.4.44L0.1204181048340.1548-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 15:08                                                                                                 ` Steven Rostedt
2012-04-18 15:24                                                                                                 ` Andrey Rahmatullin
2012-04-18 16:41                                                                                                   ` Alan Stern
     [not found]                                                                                                     ` <Pine.LNX.4.44L0.1204181228380.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 17:07                                                                                                       ` [linux-pm] " Steven Rostedt
     [not found]                                                                                                         ` <1334768847.28106.45.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-18 17:19                                                                                                           ` Alan Stern
     [not found]                                                                                                             ` <Pine.LNX.4.44L0.1204181317550.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 17:24                                                                                                               ` Steven Rostedt
     [not found]                                                                                                                 ` <1334769847.28106.47.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-18 17:46                                                                                                                   ` Mark Brown
     [not found]                                                                                                                     ` <20120418174610.GA10142-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-04-18 18:11                                                                                                                       ` Steven Rostedt
2012-04-18 20:25                                                                                                                       ` Alan Stern
2012-04-18 17:10                                                                                                     ` Andrey Rahmatullin
     [not found]                                                                                                       ` <20120418171002.GU11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-18 17:20                                                                                                         ` [linux-pm] " Steven Rostedt
     [not found]                                                                                                           ` <1334769632.28106.46.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-18 20:23                                                                                                             ` Alan Stern
     [not found]                                                                                                               ` <Pine.LNX.4.44L0.1204181616430.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 21:02                                                                                                                 ` Steven Rostedt
     [not found]                                                                                                                   ` <1334782932.28106.52.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-18 21:27                                                                                                                     ` Alan Stern
     [not found]                                                                                                                       ` <Pine.LNX.4.44L0.1204181724570.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 21:41                                                                                                                         ` Steven Rostedt
2012-04-18 21:04                                                                                                                 ` Rafael J. Wysocki
     [not found]                                                                                                                   ` <201204182304.29249.rjw-KKrjLPT3xs0@public.gmane.org>
2012-04-18 21:29                                                                                                                     ` Alan Stern
     [not found]                                                                                                                       ` <Pine.LNX.4.44L0.1204181727580.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 21:44                                                                                                                         ` Rafael J. Wysocki
2012-04-18 21:47                                                                                                                           ` Andrey Rahmatullin
2012-04-18 21:23                                                                                                               ` Andrey Rahmatullin
     [not found]                                                                                                                 ` <20120418212301.GW11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-18 21:30                                                                                                                   ` [linux-pm] " Alan Stern
     [not found]                                                                                                                     ` <Pine.LNX.4.44L0.1204181729400.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 13:43                                                                                                                       ` Alan Stern
     [not found]                                                                                                                         ` <Pine.LNX.4.44L0.1204190934500.2070-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 15:44                                                                                                                           ` Andrey Rahmatullin
     [not found]                                                                                                                             ` <20120419154453.GZ11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-19 16:05                                                                                                                               ` Alan Stern
2012-04-19 15:53                                                                                                                           ` Andrey Rahmatullin
2012-04-19 16:06                                                                                                                             ` Alan Stern
2012-04-19 16:22                                                                                                                           ` [linux-pm] " Steven Rostedt
     [not found]                                                                                                                             ` <1334852575.28106.62.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-19 18:08                                                                                                                               ` Steven Rostedt
2012-04-19 18:13                                                                                                                                 ` Alan Stern
     [not found]                                                                                                                                   ` <Pine.LNX.4.44L0.1204191411360.1154-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 18:30                                                                                                                                     ` [linux-pm] " Steven Rostedt
2012-04-19 16:30                                                                                                                           ` Andrey Rahmatullin
     [not found]                                                                                                                             ` <20120419163055.GB11484-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-19 18:07                                                                                                                               ` Alan Stern
2012-04-19 21:48                                                                                                                                 ` Andrey Rahmatullin
2012-04-21  0:42                                                                                                                                   ` Alan Stern
2012-04-21  0:53                                                                                                                                     ` Steven Rostedt
     [not found]                                                                                                                                       ` <1334969624.28106.82.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-21 17:22                                                                                                                                         ` [linux-pm] " Alan Stern
2012-04-21  8:37                                                                                                                                     ` Andrey Rahmatullin
     [not found]                                                                                                                                       ` <20120421083751.GA4570-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-21 17:26                                                                                                                                         ` [linux-pm] " Alan Stern
2012-04-21 18:50                                                                                                                                         ` Steven Rostedt
     [not found]                                                                                                                                           ` <1335034218.28106.91.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-04-21 21:51                                                                                                                                             ` Andrey Rahmatullin
2012-05-26  2:01                                                                                                                             ` Alan Stern
2012-05-26  4:03                                                                                                                               ` Steven Rostedt
2012-05-26 20:27                                                                                                                                 ` Rafael J. Wysocki
2012-05-26 21:16                                                                                                                                   ` [RFT] PCI changes related to wakeup (was: Re: ehci_hcd related S3 lockup on ASUS laptops, again) Rafael J. Wysocki
2012-05-26 21:19                                                                                                                                     ` Rafael J. Wysocki [this message]
2012-05-26 21:20                                                                                                                                     ` [RFT][PATCH 2/4] PCI / PM: Make platform choose target low-power states of more devices Rafael J. Wysocki
2012-05-26 21:21                                                                                                                                     ` [RFT][PATCH 3/4] ACPI / PM: Shorten variable name in acpi_pm_device_sleep_state() Rafael J. Wysocki
2012-05-26 21:21                                                                                                                                     ` [RFT][PATCH 4/4] ACPI / PM: Fix interactions between _SxD and _SxW Rafael J. Wysocki
2012-05-26 21:47                                                                                                                                     ` [RFT] PCI changes related to wakeup (was: Re: ehci_hcd related S3 lockup on ASUS laptops, again) Andrey Rahmatullin
2012-05-26 22:06                                                                                                                                       ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Rafael J. Wysocki
2012-05-26 22:36                                                                                                                                         ` [RFT] PCI changes related to wakeup (was: " Andrey Rahmatullin
2012-05-26 22:40                                                                                                                                           ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Alan Stern
2012-05-26 22:59                                                                                                                                             ` [RFT] PCI changes related to wakeup (was: " Rafael J. Wysocki
2012-05-29 14:23                                                                                                                                               ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Alan Stern
2012-05-29 17:29                                                                                                                                                 ` Rafael J. Wysocki
2012-05-29 18:50                                                                                                                                                   ` Alan Stern
2012-05-29 19:16                                                                                                                                                     ` Rafael J. Wysocki
2012-05-31 21:07                                                                                                                                                       ` Alan Stern
2012-05-31 21:29                                                                                                                                                         ` Rafael J. Wysocki
2012-06-01 15:13                                                                                                                                                           ` Alan Stern
2012-06-01 15:50                                                                                                                                                             ` Steven Rostedt
2012-06-01 15:59                                                                                                                                                               ` [RFT] PCI changes related to wakeup (was: " Alan Stern
2012-06-01 17:01                                                                                                                                                                 ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Steven Rostedt
2012-06-01 17:17                                                                                                                                                                   ` [RFT] PCI changes related to wakeup (was: " Alan Stern
2012-06-01 17:23                                                                                                                                                                     ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Steven Rostedt
2012-06-01 16:01                                                                                                                                                               ` [RFT] PCI changes related to wakeup (was: " Andrey Rahmatullin
2012-06-01 16:33                                                                                                                                                                 ` Alan Stern
2012-05-31 22:02                                                                                                                                                         ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Dâniel Fraga
2012-06-01 14:55                                                                                                                                                           ` Alan Stern
2012-05-31 22:25                                                                                                                                                         ` Andrey Rahmatullin
2012-06-13  9:22                                                                                                                                                         ` Rafael J. Wysocki
2012-06-13 14:21                                                                                                                                                           ` [RFT] PCI changes related to wakeup (was: " Alan Stern
2012-06-13 15:20                                                                                                                                                           ` [PATCH] PCI: add NO_D3_DURING_SLEEP flag and revert 151b61284776be2 Alan Stern
     [not found]                                                                                                                                                             ` <Pine.LNX.4.44L0.1206131117260.1401-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-13 15:27                                                                                                                                                               ` Greg KH
2012-06-13 20:04                                                                                                                                                                 ` Rafael J. Wysocki
2012-06-13 20:03                                                                                                                                                                   ` Greg KH
     [not found]                                                                                                                                                                     ` <20120613200310.GA11110-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-06-13 20:15                                                                                                                                                                       ` Steven Rostedt
     [not found]                                                                                                                                                                         ` <1339618548.13377.162.camel-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2012-06-13 20:17                                                                                                                                                                           ` Steven Rostedt
2012-06-23 21:20                                                                                                                                                               ` Pavel Pisa
     [not found]                                                                                                                                                                 ` <201206232320.15186.pisa-/N2ztlQkxE7Ub/6JBqosbQ@public.gmane.org>
2012-06-24  1:52                                                                                                                                                                   ` Alan Stern
     [not found]                                                                                                                                                                     ` <Pine.LNX.4.44L0.1206232147420.4446-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-24  7:00                                                                                                                                                                       ` Pavel Pisa
2012-05-27 16:41                                                                                                                                           ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] ehci_hcd related S3 lockup on ASUS laptops, again) Alan Stern
2012-05-27 21:17                                                                                                                                             ` Andrey Rahmatullin
2012-05-28 20:13                                                                                                                                               ` [RFT] PCI changes related to wakeup (was: " Rafael J. Wysocki
2012-05-29  7:48                                                                                                                                                 ` Andrey Rahmatullin
2012-05-29 17:30                                                                                                                                                   ` [RFT] PCI changes related to wakeup (was: Re: [linux-pm] " Rafael J. Wysocki
2012-05-29 22:39                                                                                                                                                 ` [RFT] PCI changes related to wakeup (was: " Steven Rostedt
2012-05-26  8:51                                                                                                                               ` ehci_hcd related S3 lockup on ASUS laptops, again Andrey Rahmatullin
2012-05-26 20:28                                                                                                                                 ` Rafael J. Wysocki
2012-04-18 21:10                                                                                                           ` Andrey Rahmatullin
2012-04-18 15:39                                                                                                 ` [linux-pm] " Steven Rostedt
2012-04-12 18:10                             ` Andrey Rahmatullin
2012-04-12 18:17                               ` Alan Stern
2012-04-12 18:21                                 ` Andrey Rahmatullin
2012-04-11 20:52             ` Andrey Rahmatullin
     [not found]               ` <20120411205204.GB3677-hAV9HEAGFNe6YibBOCjzsw@public.gmane.org>
2012-04-11 21:15                 ` [linux-pm] " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205262319.33464.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rostedt@goodmis.org \
    --cc=wrar@wrar.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.