All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/10] am33xx: refactor am33xx clocks and add ti814x support
Date: Fri, 15 Feb 2013 11:37:33 -0500	[thread overview]
Message-ID: <20130215163733.GK15019@bill-the-cat> (raw)
In-Reply-To: <1360766644-9901-4-git-send-email-mporter@ti.com>

On Wed, Feb 13, 2013 at 09:43:57AM -0500, Matt Porter wrote:

> Split clock.c for am335x and ti814x and add the ti814x include file.
> 
> Signed-off-by: Matt Porter <mporter@ti.com>

[snip]
> +++ b/arch/arm/cpu/armv7/am33xx/clock-am335x.c
[snip]
> +#define PRCM_MOD_EN		0x2
> +#define PRCM_FORCE_WAKEUP	0x2
> +#define PRCM_FUNCTL		0x0
> +
> +#define PRCM_EMIF_CLK_ACTIVITY	BIT(2)
> +#define PRCM_L3_GCLK_ACTIVITY	BIT(4)
> +
> +#define PLL_BYPASS_MODE		0x4
> +#define ST_MN_BYPASS		0x00000100
> +#define ST_DPLL_CLK		0x00000001
> +#define CLK_SEL_MASK		0x7ffff
> +#define CLK_DIV_MASK		0x1f
> +#define CLK_DIV2_MASK		0x7f
> +#define CLK_SEL_SHIFT		0x8
> +#define CLK_MODE_SEL		0x7
> +#define CLK_MODE_MASK		0xfffffff8
> +#define CLK_DIV_SEL		0xFFFFFFE0
> +#define CPGMAC0_IDLE		0x30000
> +#define DPLL_CLKDCOLDO_GATE_CTRL        0x300
[snip]
> +++ b/arch/arm/cpu/armv7/am33xx/clock-ti814x.c
[snip]
> +	/* Selects OSC0 (20MHz) for DMTIMER1 */
> +	temp = readl(DMTIMER_CLKSRC);
> +	temp &= ~(0x7 << 3);
> +	temp |= (0x4 << 3);
> +	writel(temp, DMTIMER_CLKSRC);
> +
> +	writel(0x2, DM_TIMER1_BASE + 0x54);

Magic values are defined for clock-am335x.c but not in clock-ti814x.c,
please fix clock-ti814x.c to define out the magic values ala am335x.c.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130215/fdda41c8/attachment.pgp>

  reply	other threads:[~2013-02-15 16:37 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 14:43 [U-Boot] [PATCH 00/10] Add TI814x EVM Support Matt Porter
2013-02-13 14:43 ` [U-Boot] [PATCH 01/10] am33xx: convert defines from am33xx-specific to generic names Matt Porter
2013-02-15 16:36   ` Tom Rini
2013-02-13 14:43 ` [U-Boot] [PATCH 02/10] am33xx: refactor emif4/ddr to support multiple EMIF instances Matt Porter
2013-02-15 16:37   ` Tom Rini
2013-02-13 14:43 ` [U-Boot] [PATCH 03/10] am33xx: refactor am33xx clocks and add ti814x support Matt Porter
2013-02-15 16:37   ` Tom Rini [this message]
     [not found]   ` <2cc71ab85c654e688082a434442f08d8@DLEE74.ent.ti.com>
2013-02-15 21:16     ` Matt Porter
2013-02-17 20:17   ` Peter Korsgaard
2013-02-25 14:31     ` Matt Porter
2013-02-13 14:43 ` [U-Boot] [PATCH 04/10] am33xx: refactor am33xx mux support " Matt Porter
2013-02-15 16:37   ` Tom Rini
2013-02-17 20:18   ` Peter Korsgaard
     [not found]   ` <463068779ea9433098998cd260b4c550@DFLE73.ent.ti.com>
2013-02-25 14:32     ` Matt Porter
2013-02-13 14:43 ` [U-Boot] [PATCH 05/10] am33xx: add ti814x specific register definitions Matt Porter
2013-02-15 16:37   ` Tom Rini
2013-02-17 20:28   ` Peter Korsgaard
2013-02-18 15:18     ` Tom Rini
2013-02-18 15:21       ` Peter Korsgaard
2013-02-21 22:08         ` Brian Hutchinson
2013-02-22 15:37           ` Peter Korsgaard
2013-02-22 15:51             ` Tom Rini
2013-02-22 16:34               ` Peter Korsgaard
     [not found]     ` <bc703446ae2c4dc79a6097dc28327030@DLEE74.ent.ti.com>
2013-02-25 14:46       ` Matt Porter
2013-02-13 14:44 ` [U-Boot] [PATCH 06/10] am33xx: add dmm support to emif4 library Matt Porter
2013-02-15 16:38   ` Tom Rini
2013-02-13 14:44 ` [U-Boot] [PATCH 07/10] ti814x_evm: add ti814x evm board support Matt Porter
2013-02-15 16:38   ` Tom Rini
     [not found]   ` <e0c6e2fe1afd4a5887b85c5b7d1877ce@DLEE74.ent.ti.com>
2013-02-15 21:19     ` Matt Porter
2013-02-13 14:44 ` [U-Boot] [PATCH 08/10] ns16550: enable quirks for ti814x Matt Porter
2013-02-15 16:38   ` Tom Rini
2013-02-13 14:44 ` [U-Boot] [PATCH 09/10] ti814x_evm: enable ti814x evm build Matt Porter
2013-02-15 16:39   ` Tom Rini
2013-02-15 21:20     ` Matt Porter
2013-02-13 14:44 ` [U-Boot] [PATCH 10/10] MAINTAINERS: add ti814x_evm maintainer Matt Porter
2013-02-15 16:39   ` Tom Rini
2013-02-15 21:21     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215163733.GK15019@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.