All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix xattr block allocation/release with bigalloc
Date: Mon, 18 Feb 2013 12:25:45 -0500	[thread overview]
Message-ID: <20130218172545.GA10843@thunk.org> (raw)
In-Reply-To: <5122480F.9030100@redhat.com>

On Mon, Feb 18, 2013 at 09:26:07AM -0600, Eric Sandeen wrote:
> On 2/18/13 2:14 AM, Lukas Czerner wrote:
> > Currently when new xattr block is created or released we we would call
> > dquot_free_block() or dquot_alloc_block() respectively, among the else
> > decrementing or incrementing the number of blocks assigned to the inode
> > by one block.
> > 
> > This however does not work for bigalloc file system because we always
> > allocate/free the whole cluster so we have to count with that in
> > dquot_free_block() and dquot_alloc_block() as well.
> > 
> > Use the clusters-to-blocks conversion EXT4_C2B() when passing number of
> > blocks to the dquot_alloc/free functions to fix the problem.
> > 
> > The problem has been revealed by xfstests #117 (and possibly others).
> > 
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>

Thanks, indeed.  Applied.

						- Ted

      reply	other threads:[~2013-02-18 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  8:14 [PATCH] ext4: fix xattr block allocation/release with bigalloc Lukas Czerner
2013-02-18 15:26 ` Eric Sandeen
2013-02-18 17:25   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218172545.GA10843@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.