From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Thu, 21 Feb 2013 09:14:34 +0000 Subject: Re: [PATCH] i2c: sh_mobile: Don't start transfers when suspending Message-Id: <20130221091434.GA22806@the-dreams.de> List-Id: References: <1360862257-10807-1-git-send-email-hechtb+renesas@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bastian Hecht Cc: Magnus Damm , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Bastian, > > Also, do you know the reason why this isn't handled in the i2c layer > > by default? I ask because your comment mentions that i2c-tegra.c does > > the same thing and I can't see anything in this patch that is actually > > related to our I2C hardware. > > Yes, many drivers have a similar scheme and to me it more looked like > all drivers need to take care about this case unrelated to different > hardware. So the question arises if this can't be handled in the core > - or if I get something wrong here. I don't see any reason why this couldn't be handled in the core. If you want to have a take on this issue (after the other bug is fixed), this will be highly appreciated. Thanks, Wolfram From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: sh_mobile: Don't start transfers when suspending Date: Thu, 21 Feb 2013 10:14:34 +0100 Message-ID: <20130221091434.GA22806@the-dreams.de> References: <1360862257-10807-1-git-send-email-hechtb+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bastian Hecht Cc: Magnus Damm , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Bastian, > > Also, do you know the reason why this isn't handled in the i2c layer > > by default? I ask because your comment mentions that i2c-tegra.c does > > the same thing and I can't see anything in this patch that is actually > > related to our I2C hardware. > > Yes, many drivers have a similar scheme and to me it more looked like > all drivers need to take care about this case unrelated to different > hardware. So the question arises if this can't be handled in the core > - or if I get something wrong here. I don't see any reason why this couldn't be handled in the core. If you want to have a take on this issue (after the other bug is fixed), this will be highly appreciated. Thanks, Wolfram