All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, mingo@redhat.com, x86@kernel.org,
	rth@twiddle.net, linux@arm.linux.org.uk, msalter@redhat.com,
	starvik@axis.com, dhowells@redhat.com, tony.luck@intel.com,
	benh@kernel.crashing.org, takata@linux-m32r.org,
	geert@linux-m68k.org, james.hogan@imgtec.com, monstr@monstr.eu,
	ralf@linux-mips.org, jonas@southpole.se, rkuo@codeaurora.org,
	liqin.chen@sunplusct.com, davem@davemloft.net,
	lethal@linux-sh.org, vgupta@synopsys.com, chris@zankel.net,
	cmetcalf@tilera.com, ysato@users.sourceforge.jp,
	gxt@mprc.pku.edu.cn, jdike@addtoit.com,
	linux-s390@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>,
	uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors
Date: Tue, 2 Apr 2013 11:26:04 -0700	[thread overview]
Message-ID: <20130402182604.GC6185@htj.dyndns.org> (raw)
In-Reply-To: <20130402084808.0c6d61f8@mschwide>

Hello, Martin.

On Tue, Apr 02, 2013 at 08:48:08AM +0200, Martin Schwidefsky wrote:
> > The couple of extra fields aren't worth an s390 version of dump_stack()
> > that differs from all other architectures.
> > Please drop the s390 version as well. Thanks!
> 
> Hmm, we would lose task_thread_info(current)->cpu and current->thread.ksp,
> I don't care much about the kernel stack pointer which has been stored at
> the last call to __switch_to but the cpu number might be interesting.
> Could we add the cpu number to the generic dump_stack version?

Yeah, I can move CPU from show_regs() to dump_stack().  It actually
makes sense.  I'll do that and convert s390 together with other archs.

Thanks!

-- 
tejun

  reply	other threads:[~2013-04-02 18:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30  2:27 [PATCHSET] arch: unify task dump debug info Tejun Heo
2013-03-30  2:27 ` [PATCH 1/5] x86: don't show trace beyond show_stack(NULL, NULL) Tejun Heo
2013-03-30  2:27 ` [PATCH 2/5] sparc32: make show_stack() acquire %fp if @_ksp is not specified Tejun Heo
2013-03-30  3:29   ` David Miller
2013-03-30  2:27 ` [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-03-30  3:30   ` David Miller
2013-03-30  5:27   ` Vineet Gupta
2013-03-30  5:27     ` Vineet Gupta
2013-03-30 11:45   ` Heiko Carstens
2013-04-02  6:48     ` Martin Schwidefsky
2013-04-02 18:26       ` Tejun Heo [this message]
2013-04-02  9:22   ` Jesper Nilsson
2013-04-16 14:59   ` James Hogan
2013-04-16 14:59     ` James Hogan
2013-03-30  2:27 ` [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps Tejun Heo
2013-04-01 18:11   ` Bjorn Helgaas
2013-04-01 18:11     ` Bjorn Helgaas
2013-04-02 18:24     ` Tejun Heo
2013-04-02 18:24       ` Tejun Heo
2013-03-30  2:27 ` [PATCH 5/5] dump_stack: unify debug information printed by show_regs() Tejun Heo
2013-03-30  3:24   ` [PATCH v2 " Tejun Heo
2013-03-30  3:30     ` David Miller
2013-03-30  6:13     ` Vineet Gupta
2013-03-30  6:13       ` Vineet Gupta
2013-04-02 18:07       ` Tejun Heo
2013-04-02  9:21     ` Jesper Nilsson
2013-04-03  4:57     ` Vineet Gupta
2013-04-03  4:57       ` Vineet Gupta
2013-04-16 15:05     ` James Hogan
2013-04-16 15:05       ` James Hogan
2013-04-02  9:24 ` [PATCHSET] arch: unify task dump debug info David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402182604.GC6185@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=chris@zankel.net \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=heiko.carstens@de.ibm.com \
    --cc=james.hogan@imgtec.com \
    --cc=jdike@addtoit.com \
    --cc=jonas@southpole.se \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.chen@sunplusct.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    --cc=vgupta@synopsys.com \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.