From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH 2/6] KVM: PPC: Add support for multiple-TCE hcalls Date: Tue, 7 May 2013 15:05:14 +1000 Message-ID: <20130507050514.GN13692@truffula.fritz.box> References: <1367825157-27231-1-git-send-email-aik@ozlabs.ru> <1367825157-27231-3-git-send-email-aik@ozlabs.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mkHYMT4O8DyWoHkb" Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Alexander Graf , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , Joerg Roedel To: Alexey Kardashevskiy Return-path: Content-Disposition: inline In-Reply-To: <1367825157-27231-3-git-send-email-aik@ozlabs.ru> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org --mkHYMT4O8DyWoHkb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 06, 2013 at 05:25:53PM +1000, Alexey Kardashevskiy wrote: > This adds real mode handlers for the H_PUT_TCE_INDIRECT and > H_STUFF_TCE hypercalls for QEMU emulated devices such as virtio > devices or emulated PCI. These calls allow adding multiple entries > (up to 512) into the TCE table in one call which saves time on > transition to/from real mode. >=20 > This adds a guest physical to host real address converter > and calls the existing H_PUT_TCE handler. The converting function > is going to be fully utilized by upcoming VFIO supporting patches. >=20 > This also implements the KVM_CAP_PPC_MULTITCE capability, > so in order to support the functionality of this patch, QEMU > needs to query for this capability and set the "hcall-multi-tce" > hypertas property only if the capability is present, otherwise > there will be serious performance degradation. >=20 > Cc: David Gibson > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: Paul Mackerras Fwiw, it would be nice to get this patch merged, regardless of the rest of the VFIO/powerpc patches. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mkHYMT4O8DyWoHkb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGIi4oACgkQaILKxv3ab8btKwCdHj3FzLAniahSk7sv0r3TlKo5 NQYAn1Jd4jU6Ka7Lbpe9r7CWioi5AqFg =bJLO -----END PGP SIGNATURE----- --mkHYMT4O8DyWoHkb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 7 May 2013 15:05:14 +1000 From: David Gibson To: Alexey Kardashevskiy Subject: Re: [PATCH 2/6] KVM: PPC: Add support for multiple-TCE hcalls Message-ID: <20130507050514.GN13692@truffula.fritz.box> References: <1367825157-27231-1-git-send-email-aik@ozlabs.ru> <1367825157-27231-3-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mkHYMT4O8DyWoHkb" In-Reply-To: <1367825157-27231-3-git-send-email-aik@ozlabs.ru> Cc: kvm@vger.kernel.org, Joerg Roedel , Alexander Graf , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --mkHYMT4O8DyWoHkb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 06, 2013 at 05:25:53PM +1000, Alexey Kardashevskiy wrote: > This adds real mode handlers for the H_PUT_TCE_INDIRECT and > H_STUFF_TCE hypercalls for QEMU emulated devices such as virtio > devices or emulated PCI. These calls allow adding multiple entries > (up to 512) into the TCE table in one call which saves time on > transition to/from real mode. >=20 > This adds a guest physical to host real address converter > and calls the existing H_PUT_TCE handler. The converting function > is going to be fully utilized by upcoming VFIO supporting patches. >=20 > This also implements the KVM_CAP_PPC_MULTITCE capability, > so in order to support the functionality of this patch, QEMU > needs to query for this capability and set the "hcall-multi-tce" > hypertas property only if the capability is present, otherwise > there will be serious performance degradation. >=20 > Cc: David Gibson > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: Paul Mackerras Fwiw, it would be nice to get this patch merged, regardless of the rest of the VFIO/powerpc patches. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mkHYMT4O8DyWoHkb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGIi4oACgkQaILKxv3ab8btKwCdHj3FzLAniahSk7sv0r3TlKo5 NQYAn1Jd4jU6Ka7Lbpe9r7CWioi5AqFg =bJLO -----END PGP SIGNATURE----- --mkHYMT4O8DyWoHkb-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Tue, 07 May 2013 05:05:14 +0000 Subject: Re: [PATCH 2/6] KVM: PPC: Add support for multiple-TCE hcalls Message-Id: <20130507050514.GN13692@truffula.fritz.box> MIME-Version: 1 Content-Type: multipart/mixed; boundary="mkHYMT4O8DyWoHkb" List-Id: References: <1367825157-27231-1-git-send-email-aik@ozlabs.ru> <1367825157-27231-3-git-send-email-aik@ozlabs.ru> In-Reply-To: <1367825157-27231-3-git-send-email-aik@ozlabs.ru> To: Alexey Kardashevskiy Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Alexander Graf , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , Joerg Roedel --mkHYMT4O8DyWoHkb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 06, 2013 at 05:25:53PM +1000, Alexey Kardashevskiy wrote: > This adds real mode handlers for the H_PUT_TCE_INDIRECT and > H_STUFF_TCE hypercalls for QEMU emulated devices such as virtio > devices or emulated PCI. These calls allow adding multiple entries > (up to 512) into the TCE table in one call which saves time on > transition to/from real mode. >=20 > This adds a guest physical to host real address converter > and calls the existing H_PUT_TCE handler. The converting function > is going to be fully utilized by upcoming VFIO supporting patches. >=20 > This also implements the KVM_CAP_PPC_MULTITCE capability, > so in order to support the functionality of this patch, QEMU > needs to query for this capability and set the "hcall-multi-tce" > hypertas property only if the capability is present, otherwise > there will be serious performance degradation. >=20 > Cc: David Gibson > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: Paul Mackerras Fwiw, it would be nice to get this patch merged, regardless of the rest of the VFIO/powerpc patches. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mkHYMT4O8DyWoHkb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGIi4oACgkQaILKxv3ab8btKwCdHj3FzLAniahSk7sv0r3TlKo5 NQYAn1Jd4jU6Ka7Lbpe9r7CWioi5AqFg =bJLO -----END PGP SIGNATURE----- --mkHYMT4O8DyWoHkb--