Re: [Powertop] Seg Fault due to function format_watts in file src/lib.cpp

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2738 bytes --]

On (05/21/13 12:20), Ganapati Bhat wrote:
>    Dear Sergey,
>    Powertop --html is working fine with the patch applied. I am able to
>    successfully execute the command and get the results. However, still
>    trying to understand the patch and the difference when I changed the 0 to
>    len in while (mbstowcs(NULL,buffer,0) < len) inside src/lib.cpp file.
>    Now, will try to adopt the latest version of powertop for android.
>    Thanks for all the help and sorry for the delay.
>    Regards,
>    Ganapati Bhat
>

Thanks Ganapati!

Kristen, could you please take a look if we can land it in upcoming
release?

https://lists.01.org/pipermail/powertop/2013-February/000782.html


Reported-and-Tested-by: Ganapati Bhat <life.mytake(a)gmail.com>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>


	-ss


 
>    On Tue, May 21, 2013 at 11:23 AM, Ganapati Bhat <[1]life.mytake(a)gmail.com>
>    wrote:
> 
>      Hello,
>      I am really sorry. i was involved in some other tasks. Will get back to
>      you in a couple of days.
>      Ganapati Bhat
> 
>      On Mon, May 20, 2013 at 6:56 PM, Sergey Senozhatsky
>      <[2]sergey.senozhatsky(a)gmail.com> wrote:
> 
>        On (02/28/13 14:45), Ganapati Bhat wrote:
>        >    Dear All,
>        >    I was compiling powertop as an Android external module and using
>        the
>        >    option powertop --html. However, there used to be a segmentation
>        fault.
>        >    When i looked into it, I observed that in the function
>        format_watts in
>        >    src/lib.cpp, the last�argument�to mbstows was zero. By changing
>        the
>        >    argument to len, which is itself an argument to the function
>        format_watts,
>        >    powertop worked properly? Does this also happen on an x86
>        machine? ( I am
>        >    unable to verify this due to some problems in my laptop which I
>        have not
>        >    yet resolved.) If not then can someone explain to me why is it
>        happening
>        >    in the case of android?
>        >    Thanks and Regards,
>        >    Ganapati
> 
>        Hello,
> 
>        did you have any chance to test the patch?
> 
>                -ss
> 
>        > _______________________________________________
>        > PowerTop mailing list
>        > [3]PowerTop(a)lists.01.org
>        > [4]https://lists.01.org/mailman/listinfo/powertop
> 
> References
> 
>    Visible links
>    1. mailto:life.mytake(a)gmail.com
>    2. mailto:sergey.senozhatsky(a)gmail.com
>    3. mailto:PowerTop(a)lists.01.org
>    4. https://lists.01.org/mailman/listinfo/powertop