From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzteB-00019l-Kz for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uzte8-0002BD-Pt for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:13:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzte8-0002B6-Ij for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:13:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IJDl1F005516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 15:13:47 -0400 Date: Thu, 18 Jul 2013 12:13:44 -0700 From: Ian Main Message-ID: <20130718191344.GD13675@gate.mains.priv> References: <1374173251-19449-1-git-send-email-imain@redhat.com> <51E83A73.9070501@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E83A73.9070501@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote: > On 07/18/2013 12:47 PM, Ian Main wrote: > > qcow2 supports backing files so it makes sense to default to qcow2 > > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > > drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE > > breaks tests but that could be fixed if we wanted it. > > > > Signed-off-by: Ian Main > > --- > > blockdev.c | 5 ++++- > > qapi-schema.json | 1 + > > 2 files changed, 5 insertions(+), 1 deletion(-) > > Looks okay, but let's answer the meta-question first of whether we > should just make 'format' mandatory and be done with it. > > Also, I've noticed you aren't cc'ing many people; that can slow down > reviews. http://wiki.qemu.org/Contribute/SubmitAPatch gives hints on > how to determine the right people to send your patches to, by > deciphering MAINTAINERS and running ./scripts/getmaintainer.pl. Ah ok, I'll add them next rev. My take has been to just do a patch that implements the suggestion and see what people think :). Ian