From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v3 16/31] dts: mpc512x: add clock related device tree specs Date: Fri, 02 Aug 2013 15:46:13 -0700 Message-ID: <20130802224613.6450.5857@quantum> References: <1374166855-7280-1-git-send-email-gsi@denx.de> <1374495298-22019-1-git-send-email-gsi@denx.de> <1374495298-22019-17-git-send-email-gsi@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374495298-22019-17-git-send-email-gsi@denx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: linuxppc-dev@lists.ozlabs.org, Anatolij Gustschin , linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org Cc: Detlev Zundel , Wolfram Sang , Greg Kroah-Hartman , Gerhard Sittig , Rob Herring , Mark Brown , Marc Kleine-Budde , David Woodhouse , Wolfgang Grandegger , Mauro Carvalho Chehab List-Id: devicetree@vger.kernel.org Quoting Gerhard Sittig (2013-07-22 05:14:43) > this addresses the clock driver aka provider's side of clocks > - prepare for future '<&clks ID>' phandle references for device tree > based clock lookup in client drivers > - introduce a 'clocks' subtree with an 'osc' node for the crystal > or oscillator SoC input (fixed frequency) > - provide default values with 33MHz oscillator frequency in the > common include (the 66MHz IPS bus already was there), add > override values for the ifm AC14xx board which deviates from > the reference design (25MHz xtal, 80MHz IPS bus) > > Signed-off-by: Gerhard Sittig Reviewed-by: Mike Turquette > --- > arch/powerpc/boot/dts/ac14xx.dts | 7 +++++++ > arch/powerpc/boot/dts/mpc5121.dtsi | 15 ++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts > index a543c40..a1b8837 100644 > --- a/arch/powerpc/boot/dts/ac14xx.dts > +++ b/arch/powerpc/boot/dts/ac14xx.dts > @@ -139,7 +139,14 @@ > }; > }; > > + clocks { > + osc { > + clock-frequency = <25000000>; > + }; > + }; > + > soc@80000000 { > + bus-frequency = <80000000>; /* 80 MHz ips bus */ > > clock@f00 { > compatible = "fsl,mpc5121rev2-clock", "fsl,mpc5121-clock"; > diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/mpc5121.dtsi > index bd14c00..8f4cba0 100644 > --- a/arch/powerpc/boot/dts/mpc5121.dtsi > +++ b/arch/powerpc/boot/dts/mpc5121.dtsi > @@ -9,6 +9,8 @@ > * option) any later version. > */ > > +#include > + > /dts-v1/; > > / { > @@ -73,6 +75,16 @@ > ranges = <0x0 0x0 0xfc000000 0x04000000>; > }; > > + clocks { > + #address-cells = <1>; > + #size-cells = <0>; > + > + osc { > + compatible = "fsl,mpc512x-osc", "fixed-clock"; > + clock-frequency = <33000000>; > + }; > + }; > + > soc@80000000 { > compatible = "fsl,mpc5121-immr"; > #address-cells = <1>; > @@ -118,9 +130,10 @@ > }; > > /* Clock control */ > - clock@f00 { > + clks: clock@f00 { > compatible = "fsl,mpc5121-clock"; > reg = <0xf00 0x100>; > + #clock-cells = <1>; > }; > > /* Power Management Controller */ > -- > 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4346B2C0095 for ; Sat, 3 Aug 2013 08:46:19 +1000 (EST) Received: by mail-pd0-f169.google.com with SMTP id y11so1146264pdj.14 for ; Fri, 02 Aug 2013 15:46:17 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Gerhard Sittig , linuxppc-dev@lists.ozlabs.org, Anatolij Gustschin , linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org From: Mike Turquette In-Reply-To: <1374495298-22019-17-git-send-email-gsi@denx.de> References: <1374166855-7280-1-git-send-email-gsi@denx.de> <1374495298-22019-1-git-send-email-gsi@denx.de> <1374495298-22019-17-git-send-email-gsi@denx.de> Message-ID: <20130802224613.6450.5857@quantum> Subject: Re: [PATCH v3 16/31] dts: mpc512x: add clock related device tree specs Date: Fri, 02 Aug 2013 15:46:13 -0700 Cc: Detlev Zundel , Wolfram Sang , Greg Kroah-Hartman , Gerhard Sittig , Rob Herring , Mark Brown , Marc Kleine-Budde , David Woodhouse , Wolfgang Grandegger , Mauro Carvalho Chehab List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Quoting Gerhard Sittig (2013-07-22 05:14:43) > this addresses the clock driver aka provider's side of clocks > - prepare for future '<&clks ID>' phandle references for device tree > based clock lookup in client drivers > - introduce a 'clocks' subtree with an 'osc' node for the crystal > or oscillator SoC input (fixed frequency) > - provide default values with 33MHz oscillator frequency in the > common include (the 66MHz IPS bus already was there), add > override values for the ifm AC14xx board which deviates from > the reference design (25MHz xtal, 80MHz IPS bus) > = > Signed-off-by: Gerhard Sittig Reviewed-by: Mike Turquette > --- > arch/powerpc/boot/dts/ac14xx.dts | 7 +++++++ > arch/powerpc/boot/dts/mpc5121.dtsi | 15 ++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) > = > diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac1= 4xx.dts > index a543c40..a1b8837 100644 > --- a/arch/powerpc/boot/dts/ac14xx.dts > +++ b/arch/powerpc/boot/dts/ac14xx.dts > @@ -139,7 +139,14 @@ > }; > }; > = > + clocks { > + osc { > + clock-frequency =3D <25000000>; > + }; > + }; > + > soc@80000000 { > + bus-frequency =3D <80000000>; /* 80 MHz ips bus */ > = > clock@f00 { > compatible =3D "fsl,mpc5121rev2-clock", "fsl,mpc5= 121-clock"; > diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/m= pc5121.dtsi > index bd14c00..8f4cba0 100644 > --- a/arch/powerpc/boot/dts/mpc5121.dtsi > +++ b/arch/powerpc/boot/dts/mpc5121.dtsi > @@ -9,6 +9,8 @@ > * option) any later version. > */ > = > +#include > + > /dts-v1/; > = > / { > @@ -73,6 +75,16 @@ > ranges =3D <0x0 0x0 0xfc000000 0x04000000>; > }; > = > + clocks { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + osc { > + compatible =3D "fsl,mpc512x-osc", "fixed-clock"; > + clock-frequency =3D <33000000>; > + }; > + }; > + > soc@80000000 { > compatible =3D "fsl,mpc5121-immr"; > #address-cells =3D <1>; > @@ -118,9 +130,10 @@ > }; > = > /* Clock control */ > - clock@f00 { > + clks: clock@f00 { > compatible =3D "fsl,mpc5121-clock"; > reg =3D <0xf00 0x100>; > + #clock-cells =3D <1>; > }; > = > /* Power Management Controller */ > -- = > 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Fri, 02 Aug 2013 15:46:13 -0700 Subject: [PATCH v3 16/31] dts: mpc512x: add clock related device tree specs In-Reply-To: <1374495298-22019-17-git-send-email-gsi@denx.de> References: <1374166855-7280-1-git-send-email-gsi@denx.de> <1374495298-22019-1-git-send-email-gsi@denx.de> <1374495298-22019-17-git-send-email-gsi@denx.de> Message-ID: <20130802224613.6450.5857@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Gerhard Sittig (2013-07-22 05:14:43) > this addresses the clock driver aka provider's side of clocks > - prepare for future '<&clks ID>' phandle references for device tree > based clock lookup in client drivers > - introduce a 'clocks' subtree with an 'osc' node for the crystal > or oscillator SoC input (fixed frequency) > - provide default values with 33MHz oscillator frequency in the > common include (the 66MHz IPS bus already was there), add > override values for the ifm AC14xx board which deviates from > the reference design (25MHz xtal, 80MHz IPS bus) > > Signed-off-by: Gerhard Sittig Reviewed-by: Mike Turquette > --- > arch/powerpc/boot/dts/ac14xx.dts | 7 +++++++ > arch/powerpc/boot/dts/mpc5121.dtsi | 15 ++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts > index a543c40..a1b8837 100644 > --- a/arch/powerpc/boot/dts/ac14xx.dts > +++ b/arch/powerpc/boot/dts/ac14xx.dts > @@ -139,7 +139,14 @@ > }; > }; > > + clocks { > + osc { > + clock-frequency = <25000000>; > + }; > + }; > + > soc at 80000000 { > + bus-frequency = <80000000>; /* 80 MHz ips bus */ > > clock at f00 { > compatible = "fsl,mpc5121rev2-clock", "fsl,mpc5121-clock"; > diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/mpc5121.dtsi > index bd14c00..8f4cba0 100644 > --- a/arch/powerpc/boot/dts/mpc5121.dtsi > +++ b/arch/powerpc/boot/dts/mpc5121.dtsi > @@ -9,6 +9,8 @@ > * option) any later version. > */ > > +#include > + > /dts-v1/; > > / { > @@ -73,6 +75,16 @@ > ranges = <0x0 0x0 0xfc000000 0x04000000>; > }; > > + clocks { > + #address-cells = <1>; > + #size-cells = <0>; > + > + osc { > + compatible = "fsl,mpc512x-osc", "fixed-clock"; > + clock-frequency = <33000000>; > + }; > + }; > + > soc at 80000000 { > compatible = "fsl,mpc5121-immr"; > #address-cells = <1>; > @@ -118,9 +130,10 @@ > }; > > /* Clock control */ > - clock at f00 { > + clks: clock at f00 { > compatible = "fsl,mpc5121-clock"; > reg = <0xf00 0x100>; > + #clock-cells = <1>; > }; > > /* Power Management Controller */ > -- > 1.7.10.4