From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 45/50] drm/<drivers>: don't set driver->dev_priv_size to 0
Date: Fri, 10 Jan 2014 15:25:32 +0000
Message-ID: <20140110152532.GC7892@strange.amr.corp.intel.com>
References: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch>
	<1386758111-3446-46-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id A40EB105850
	for <dri-devel@lists.freedesktop.org>;
	Fri, 10 Jan 2014 07:25:34 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1386758111-3446-46-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Wed, Dec 11, 2013 at 11:35:06AM +0100, Daniel Vetter wrote:
> Especially not on modesetting drivers - this is used to size
> the driver private structure for legacy drm buffers.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I managed to write the same patch one month later, so:

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/ast/ast_drv.c       | 1 -
>  drivers/gpu/drm/qxl/qxl_drv.c       | 1 -
>  drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 5137f15dba19..2ba39ac7d222 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -198,7 +198,6 @@ static const struct file_operations ast_fops = {
>  
>  static struct drm_driver driver = {
>  	.driver_features = DRIVER_MODESET | DRIVER_GEM,
> -	.dev_priv_size = 0,
>  
>  	.load = ast_driver_load,
>  	.unload = ast_driver_unload,
> diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
> index fee8748bdca5..6e936634d65c 100644
> --- a/drivers/gpu/drm/qxl/qxl_drv.c
> +++ b/drivers/gpu/drm/qxl/qxl_drv.c
> @@ -214,7 +214,6 @@ static struct pci_driver qxl_pci_driver = {
>  static struct drm_driver qxl_driver = {
>  	.driver_features = DRIVER_GEM | DRIVER_MODESET |
>  			   DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED,
> -	.dev_priv_size = 0,
>  	.load = qxl_driver_load,
>  	.unload = qxl_driver_unload,
>  
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index f6f30b9e9ff5..a16e56325bfd 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -522,7 +522,6 @@ static struct drm_driver kms_driver = {
>  	    DRIVER_USE_AGP |
>  	    DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED | DRIVER_GEM |
>  	    DRIVER_PRIME | DRIVER_RENDER,
> -	.dev_priv_size = 0,
>  	.load = radeon_driver_load_kms,
>  	.open = radeon_driver_open_kms,
>  	.preclose = radeon_driver_preclose_kms,
> -- 
> 1.8.4.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel