From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753799AbaEOMMT (ORCPT ); Thu, 15 May 2014 08:12:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9755 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbaEOMMP (ORCPT ); Thu, 15 May 2014 08:12:15 -0400 Date: Thu, 15 May 2014 14:11:52 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , David Ahern , Andi Kleen , Don Zickus Subject: Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines Message-ID: <20140515121152.GB25858@krava.brq.redhat.com> References: <1399876133-17963-1-git-send-email-namhyung@kernel.org> <1399876133-17963-7-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399876133-17963-7-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c > index 9eccf7f4f367..e6920d124c60 100644 > --- a/tools/perf/ui/stdio/hist.c > +++ b/tools/perf/ui/stdio/hist.c > @@ -353,8 +353,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size, > if (size == 0 || size > bfsz) > size = hpp.size = bfsz; > > - ret = hist_entry__period_snprintf(&hpp, he); > - hist_entry__sort_snprintf(he, bf + ret, size - ret, hists); > + hist_entry__period_snprintf(&hpp, he); hm, how about hist_browser__fprintf_entry.. looks like it could use just hist_entry__period_snprintf as well and we could get rid hist_entry__sort_snprintf completely thanks, jirka