All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 3/5] armv8/fsl-lsch3: Release secondary cores from boot hold off with Boot Page
Date: Fri, 22 Aug 2014 12:41:40 +0100	[thread overview]
Message-ID: <20140822114140.GV21734@leverpostej> (raw)
In-Reply-To: <53F63B55.3040900@freescale.com>

Hi York,

> >> -       /*
> >> -        * All processors will enter EL2 and optionally EL1.
> >> +slave_cpu:
> >> +       wfe
> >> +#ifdef CONFIG_FSL_SMP_RELEASE_ALL
> >> +       /* All cores are released from the address in the 1st spin table
> >> +        * element
> >>          */
> >> -       bl      armv8_switch_to_el2
> >> -#ifdef CONFIG_ARMV8_SWITCH_TO_EL1
> >> -       bl      armv8_switch_to_el1
> >> +       ldr     x1, =__spin_table
> >> +       ldr     x0, [x1]
> >> +#else
> >> +       ldr     x0, [x11]
> >> +#endif
> >> +       cbz     x0, slave_cpu
> >
> > Similarly is there any reason to have the option of a single release
> > addr if we can support unique addresses?
> 
> I think it was used by Linux for some ARM parts. I personally not a fun of using
> single release.

That makes two of us. The single release address on those ARM dts is a
legacy mistake that we can't fix up without breaking some models. We
don't need to propagate that mistake to new platforms.

> But if it makes everyone happy, I can keep it.

I'd be happier with CONFIG_FSL_SMP_RELEASE_ALL dropped entirely. Ideally
U-Boot would always provide a unique cpu-release-address for each CPU. 

Thanks,
Mark.

  parent reply	other threads:[~2014-08-22 11:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 20:27 [U-Boot] [Patch v2 1/5] fdt_support: Move of_read_number to fdt_support.h York Sun
2014-08-19 20:27 ` [U-Boot] [Patch v2 2/5] fdt_support: Make of_bus_default_count_cells non static York Sun
2014-08-19 20:28 ` [U-Boot] [Patch v2 3/5] armv8/fsl-lsch3: Release secondary cores from boot hold off with Boot Page York Sun
2014-08-21 13:47   ` Mark Rutland
2014-08-21 18:32     ` York Sun
2014-08-21 18:50       ` bhupesh.sharma at freescale.com
2014-08-22  7:02         ` Arnab Basu
2014-08-22 11:24           ` Mark Rutland
2014-08-22 11:38         ` Mark Rutland
2014-08-22 11:41       ` Mark Rutland [this message]
2014-08-19 20:28 ` [U-Boot] [Patch v2 4/5] ARMv8/ls2085a: Enable secondary cores York Sun
2014-08-19 20:28 ` [U-Boot] [Patch v2 5/5] ARMv8/ls2085a: Move u-boot location to make room for RCW York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140822114140.GV21734@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.