From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Patrick McHardy <kaber@trash.net>,
davem@davemloft.net, paulmck@linux.vnet.ibm.com,
ying.xue@windriver.com, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] netlink: Lock out table resizes while dumping Netlink sockets
Date: Wed, 21 Jan 2015 10:34:21 +0000 [thread overview]
Message-ID: <20150121103421.GR20315@casper.infradead.org> (raw)
In-Reply-To: <20150121095837.GA25750@gondor.apana.org.au>
On 01/21/15 at 08:58pm, Herbert Xu wrote:
> On Wed, Jan 21, 2015 at 09:49:28AM +0000, Thomas Graf wrote:
> >
> > An entry can move between different tables and thus chains need to be
> > marked to identify what list a lookup ended up searching in. It's not
> > the nulls marker itself that is needed, it's the bits in the last next
> > pointer identifying the list that the nulls marker allows to be used
> > which are essential.
>
> Can you describe in more detail how it's going to be used? I don't
> see how I could use the bit if you need it to indicate the end of
> the list.
Another thought: Instead of storing that bit in the next pointer, we
could require the user to store this bit, i.e. two new function
pointers to rhashtable_params, set_walk_bit() and get_walk_bit(),
which take the hashed object as argument and if a rhashtable user
requires consistent dumps he can provide these functions to store
the flag.
next prev parent reply other threads:[~2015-01-21 10:34 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 13:20 [PATCH 0/3 net-next] rhashtable: Notify on resize to allow signaling interrupted dumps Thomas Graf
2015-01-20 13:20 ` [PATCH 1/3] rhashtable: Provide notifier for deferred resizes Thomas Graf
2015-01-20 13:20 ` [PATCH 2/3] netlink: Mark dumps as inconsistent which have been interrupted by a resize Thomas Graf
2015-01-21 8:13 ` Ying Xue
2015-01-21 12:17 ` Thomas Graf
2015-01-22 8:49 ` Herbert Xu
2015-01-22 8:56 ` Patrick McHardy
2015-01-22 9:22 ` Herbert Xu
2015-01-22 10:07 ` Patrick McHardy
2015-01-25 23:20 ` [PATCH 0/2] rhashtable: Add walk iterator primitives and use them in netlink Herbert Xu
2015-01-25 23:21 ` [PATCH 1/2] rhashtable: Introduce rhashtable_walk_* Herbert Xu
2015-01-26 8:20 ` Thomas Graf
2015-01-26 22:21 ` Herbert Xu
2015-01-26 10:09 ` David Laight
2015-01-26 22:23 ` Herbert Xu
2015-01-26 22:36 ` David Miller
2015-01-26 22:42 ` Herbert Xu
2015-01-26 23:31 ` Herbert Xu
2015-01-27 9:45 ` Thomas Graf
2015-01-27 9:54 ` Herbert Xu
2015-01-27 10:15 ` Thomas Graf
2015-01-27 10:24 ` Herbert Xu
2015-01-27 11:16 ` Thomas Graf
2015-01-27 11:23 ` Herbert Xu
2015-01-27 11:40 ` Thomas Graf
2015-01-27 20:39 ` Herbert Xu
2015-01-27 22:10 ` David Miller
2015-01-27 23:16 ` Herbert Xu
2015-01-27 13:09 ` Patrick McHardy
2015-01-27 20:36 ` Herbert Xu
2015-01-28 19:07 ` Patrick McHardy
2015-01-30 5:58 ` Herbert Xu
2015-01-30 8:10 ` Patrick McHardy
2015-01-27 10:09 ` David Laight
2015-01-27 10:12 ` Herbert Xu
2015-01-25 23:21 ` [PATCH 2/2] netlink: Use rhashtable walk iterator Herbert Xu
2015-01-27 23:19 ` [PATCH 0/2] rhashtable: Add walk iterator primitives and use them in netlink Herbert Xu
2015-01-27 23:20 ` [PATCH 1/2] rhashtable: Introduce rhashtable_walk_* Herbert Xu
2015-01-29 22:26 ` Thomas Graf
2015-01-27 23:20 ` [PATCH 2/2] netlink: Use rhashtable walk iterator Herbert Xu
2015-01-29 22:27 ` Thomas Graf
2015-01-29 22:42 ` [PATCH 0/2] rhashtable: Add walk iterator primitives and use them in netlink David Miller
2015-01-31 3:13 ` Herbert Xu
2015-01-31 3:14 ` [PATCH 1/2] rhashtable: Introduce rhashtable_walk_* Herbert Xu
2015-01-31 3:14 ` [PATCH 2/2] netlink: Use rhashtable walk iterator Herbert Xu
2015-01-31 4:31 ` netfilter: " Herbert Xu
2015-02-01 7:45 ` Patrick McHardy
2015-02-03 3:19 ` David Miller
2015-02-03 3:19 ` [PATCH 0/2] rhashtable: Add walk iterator primitives and use them in netlink David Miller
2015-01-20 13:20 ` [PATCH 3/3] netlink: Lock out table resizes while dumping Netlink sockets Thomas Graf
2015-01-20 14:31 ` Patrick McHardy
2015-01-20 14:55 ` Thomas Graf
2015-01-20 15:21 ` Patrick McHardy
2015-01-20 15:35 ` Thomas Graf
2015-01-21 5:08 ` Herbert Xu
2015-01-21 5:15 ` Herbert Xu
2015-01-21 9:14 ` Herbert Xu
2015-01-21 9:56 ` Thomas Graf
2015-01-21 9:59 ` Herbert Xu
2015-01-21 10:00 ` Patrick McHardy
2015-01-21 9:37 ` Thomas Graf
2015-01-21 9:38 ` Herbert Xu
2015-01-21 9:49 ` Thomas Graf
2015-01-21 9:58 ` Herbert Xu
2015-01-21 10:23 ` Thomas Graf
2015-01-22 6:35 ` Herbert Xu
2015-01-22 7:20 ` Herbert Xu
2015-01-22 9:05 ` Thomas Graf
2015-01-22 9:50 ` Herbert Xu
2015-01-21 10:34 ` Thomas Graf [this message]
2015-01-21 10:40 ` Patrick McHardy
2015-01-21 11:37 ` Thomas Graf
2015-01-21 11:59 ` Patrick McHardy
2015-01-21 12:07 ` Thomas Graf
2015-01-21 12:09 ` Patrick McHardy
2015-01-21 10:36 ` David Laight
2015-01-20 15:00 ` David Laight
2015-01-20 15:05 ` Thomas Graf
2015-01-21 5:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121103421.GR20315@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.