All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: "Dumitrescu,
	Cristian"
	<cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org"
	<dev-VfR2kkLFssw@public.gmane.org>,
	Stephen Hemminger
	<shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 4/7] rte_sched: don't clear statistics when	read
Date: Mon, 9 Feb 2015 14:55:09 -0800	[thread overview]
Message-ID: <20150209145509.1b7bea9b@uryu.home.lan> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323097BA-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>

On Mon, 9 Feb 2015 22:48:36 +0000
"Dumitrescu, Cristian" <cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

> Hi Stephen,
> 
> What is the reason not to clear statistics on read? Do you have a use-case / justification for it?
> 
> (BTW, I see you added the reset functions, but was it also your intention to remove the memset to 0 from the stats read functions? :) )
> 
> Regards,
> Cristian

Read and clear is a non-standard model. Interface statistics are not read/clear.
We have lots of scripts that read statistics. Users don't like it if when 
stastics disappear.

  parent reply	other threads:[~2015-02-09 22:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  6:13 [PATCH v2 4/7] rte_sched: don't clear statistics when read Stephen Hemminger
     [not found] ` <1423116841-19799-4-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-05  6:13   ` [PATCH v2 5/7] rte_sched: don't put tabs in log messages Stephen Hemminger
     [not found]     ` <1423116841-19799-5-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-20 18:33       ` Dumitrescu, Cristian
2015-02-05  6:14   ` [PATCH v2 6/7] rte_sched: eliminate floating point in calculating byte clock Stephen Hemminger
     [not found]     ` <1423116841-19799-6-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-16 22:44       ` Dumitrescu, Cristian
     [not found]         ` <3EB4FA525960D640B5BDFFD6A3D8912632318070-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-17 16:05           ` Stephen Hemminger
2015-02-05  6:14   ` [PATCH v2 7/7] rte_sched: rearrange data structures Stephen Hemminger
     [not found]     ` <1423116841-19799-7-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-20 18:43       ` Dumitrescu, Cristian
2015-02-05 12:43   ` [PATCH v2 4/7] rte_sched: don't clear statistics when read Neil Horman
     [not found]     ` <20150205124330.GB28355-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-02-23 23:51       ` Thomas Monjalon
     [not found]     ` <fa17ab0c3bc041b88e18d3d76a255f13@HQ1WP-EXMB11.corp.brocade.com>
     [not found]       ` <fa17ab0c3bc041b88e18d3d76a255f13-2C8+kldvbBwA50eAn2D9H4CDckiq/fhJZeezCHUQhQ4@public.gmane.org>
2015-02-24 19:18         ` Stephen Hemminger
2015-02-24 20:06           ` Thomas Monjalon
2015-02-25 17:29             ` Dumitrescu, Cristian
2015-03-10 13:55             ` Thomas Monjalon
2015-02-09 22:48   ` Dumitrescu, Cristian
     [not found]     ` <3EB4FA525960D640B5BDFFD6A3D89126323097BA-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-09 22:55       ` Stephen Hemminger [this message]
     [not found]         ` <20150209145509.1b7bea9b-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
2015-02-20 18:32           ` Dumitrescu, Cristian
     [not found]             ` <3EB4FA525960D640B5BDFFD6A3D891263231B296-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-20 19:52               ` Stephen Hemminger
2015-02-20 20:23                 ` Dumitrescu, Cristian
     [not found]                   ` <3EB4FA525960D640B5BDFFD6A3D891263231B33C-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-20 21:01                     ` Thomas Monjalon
2015-02-20 21:28                       ` Dumitrescu, Cristian
     [not found]                         ` <3EB4FA525960D640B5BDFFD6A3D891263231B3B2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-21  1:53                           ` Stephen Hemminger
2015-02-23 12:06                             ` Dumitrescu, Cristian
2015-02-09 23:46       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209145509.1b7bea9b@uryu.home.lan \
    --to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
    --cc=cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.