All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
	ian.campbell@citrix.com, steve@zentific.com,
	stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com,
	tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	eddie.dong@intel.com, andres@lagarcavilla.org, jbeulich@suse.com,
	rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov,
	yanghy@cn.fujitsu.com
Subject: Re: [PATCH V4 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl
Date: Fri, 13 Feb 2015 12:12:33 +0000	[thread overview]
Message-ID: <20150213121233.GS13644@zion.uk.xensource.com> (raw)
In-Reply-To: <1423508018-22188-14-git-send-email-tamas.lengyel@zentific.com>

On Mon, Feb 09, 2015 at 07:53:38PM +0100, Tamas K Lengyel wrote:
> Thus far mem_access and mem_sharing memops had been able to signal
> to Xen to start pulling responses off the corresponding rings. In this patch
> we retire these memops and add them to the option to the vm_event_op domctl.
> 
> The vm_event_op domctl suboptions are the same for each ring thus we
> consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME.
> 
> As part of this patch in libxc we also rename the mem_access_enable/disable
> functions to monitor_enable/disable and move them into xc_monitor.c.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
> ---
>  tools/libxc/include/xenctrl.h       | 22 ++++++++++-----------
>  tools/libxc/xc_mem_access.c         | 25 ------------------------
>  tools/libxc/xc_mem_paging.c         | 12 ++++++++++--
>  tools/libxc/xc_memshr.c             | 15 ++++++--------
>  tools/libxc/xc_monitor.c            | 22 +++++++++++++++++++++
>  tools/libxc/xc_vm_event.c           |  6 +++---

I've only skimmed this patch but most of these are mechanical changes.
We are relatively lax on libxc interface, so this part looks good
to me.

Acked-by: Wei Liu <wei.liu2@citrix.com>

      reply	other threads:[~2015-02-13 12:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 18:53 [PATCH V4 00/13] xen: Clean-up of mem_event subsystem Tamas K Lengyel
2015-02-09 18:53 ` [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel
2015-02-10 12:52   ` Jan Beulich
2015-02-10 13:50     ` Tamas K Lengyel
2015-02-10 16:17       ` Jan Beulich
2015-02-10 16:38         ` Tamas K Lengyel
2015-02-10 17:39           ` Jan Beulich
2015-02-10 18:03             ` Tamas K Lengyel
2015-02-11  7:43               ` Jan Beulich
2015-02-09 18:53 ` [PATCH V4 02/13] xen/mem_event: Cleanup mem_event ring names and domctls Tamas K Lengyel
2015-02-10 12:56   ` Jan Beulich
2015-02-09 18:53 ` [PATCH V4 03/13] xen/mem_paging: Convert mem_event_op to mem_paging_op Tamas K Lengyel
2015-02-10 13:00   ` Jan Beulich
2015-02-09 18:53 ` [PATCH V4 04/13] xen/mem_access: Merge mem_event sanity check into mem_access check Tamas K Lengyel
2015-02-09 18:53 ` [PATCH V4 05/13] xen: Rename mem_event to vm_event Tamas K Lengyel
2015-02-09 20:09   ` Daniel De Graaf
2015-02-10 13:06   ` Jan Beulich
2015-02-13 12:13   ` Wei Liu
2015-02-09 18:53 ` [PATCH V4 06/13] tools/tests: Clean-up tools/tests/xen-access Tamas K Lengyel
2015-02-09 18:53 ` [PATCH V4 07/13] x86/hvm: factor out and rename vm_event related functions Tamas K Lengyel
2015-02-10 13:15   ` Jan Beulich
2015-02-09 18:53 ` [PATCH V4 08/13] xen: Introduce monitor_op domctl Tamas K Lengyel
2015-02-09 20:09   ` Daniel De Graaf
2015-02-09 18:53 ` [PATCH V4 09/13] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds Tamas K Lengyel
2015-02-09 18:53 ` [PATCH V4 10/13] xen/vm_event: Decouple vm_event and mem_access Tamas K Lengyel
2015-02-09 20:09   ` Daniel De Graaf
2015-02-09 18:53 ` [PATCH V4 11/13] xen/vm_event: Relocate memop checks Tamas K Lengyel
2015-02-09 18:53 ` [PATCH V4 12/13] xen/xsm: Split vm_event_op into three separate labels Tamas K Lengyel
2015-02-09 20:09   ` Daniel De Graaf
2015-02-09 18:53 ` [PATCH V4 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl Tamas K Lengyel
2015-02-13 12:12   ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150213121233.GS13644@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=andres@lagarcavilla.org \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=steve@zentific.com \
    --cc=tamas.lengyel@zentific.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.