From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVDAg-0001SR-RY for qemu-devel@nongnu.org; Tue, 10 Mar 2015 01:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVDAe-0003Zk-AN for qemu-devel@nongnu.org; Tue, 10 Mar 2015 01:57:38 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:59794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVDAd-0003Yb-ME for qemu-devel@nongnu.org; Tue, 10 Mar 2015 01:57:36 -0400 Date: Tue, 10 Mar 2015 16:47:25 +1100 From: David Gibson Message-ID: <20150310054725.GC11973@voom.redhat.com> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-12-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV" Content-Disposition: inline In-Reply-To: <1424883128-9841-12-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com --6zdv2QT/q3FMhpsV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2015 at 04:51:34PM +0000, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > Add migrate_send_rp_message to send a message from destination to source = along the return path. > (It uses a mutex to let it be called from multiple threads) > Add migrate_send_rp_shut to send a 'shut' message to indicate > the destination is finished with the RP. > Add migrate_send_rp_ack to send a 'PONG' message in response to a PING > Use it in the CMD_PING handler >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 17 ++++++++++++++++ > migration/migration.c | 45 +++++++++++++++++++++++++++++++++++++= ++++++ > savevm.c | 2 +- > trace-events | 1 + > 4 files changed, 64 insertions(+), 1 deletion(-) >=20 > diff --git a/include/migration/migration.h b/include/migration/migration.h > index c514dd4..6775747 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -41,6 +41,13 @@ struct MigrationParams { > bool shared; > }; > =20 > +/* Commands sent on the return path from destination to source*/ > +enum mig_rpcomm_cmd { "command" doesn't seem like quite the right description for these rp messages. > + MIG_RP_CMD_INVALID =3D 0, /* Must be 0 */ > + MIG_RP_CMD_SHUT, /* sibling will not send any more RP messag= es */ > + MIG_RP_CMD_PONG, /* Response to a PING; data (seq: be32 ) */ > +}; > + > typedef struct MigrationState MigrationState; > =20 > /* State for the incoming migration */ > @@ -48,6 +55,7 @@ struct MigrationIncomingState { > QEMUFile *file; > =20 > QEMUFile *return_path; > + QemuMutex rp_mutex; /* We send replies from multiple threads= */ > }; > =20 > MigrationIncomingState *migration_incoming_get_current(void); > @@ -169,6 +177,15 @@ int64_t migrate_xbzrle_cache_size(void); > =20 > int64_t xbzrle_cache_resize(int64_t new_size); > =20 > +/* Sending on the return path - generic and then for each message type */ > +void migrate_send_rp_message(MigrationIncomingState *mis, > + enum mig_rpcomm_cmd cmd, > + uint16_t len, uint8_t *data); > +void migrate_send_rp_shut(MigrationIncomingState *mis, > + uint32_t value); > +void migrate_send_rp_pong(MigrationIncomingState *mis, > + uint32_t value); > + > void ram_control_before_iterate(QEMUFile *f, uint64_t flags); > void ram_control_after_iterate(QEMUFile *f, uint64_t flags); > void ram_control_load_hook(QEMUFile *f, uint64_t flags); > diff --git a/migration/migration.c b/migration/migration.c > index a36ea65..80d234c 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -78,6 +78,7 @@ MigrationIncomingState *migration_incoming_state_new(QE= MUFile* f) > { > mis_current =3D g_malloc0(sizeof(MigrationIncomingState)); > mis_current->file =3D f; > + qemu_mutex_init(&mis_current->rp_mutex); > =20 > return mis_current; > } > @@ -88,6 +89,50 @@ void migration_incoming_state_destroy(void) > mis_current =3D NULL; > } > =20 > +/* > + * Send a message on the return channel back to the source > + * of the migration. > + */ > +void migrate_send_rp_message(MigrationIncomingState *mis, > + enum mig_rpcomm_cmd cmd, > + uint16_t len, uint8_t *data) Using (void *) for data would avoid casts in a bunch of the callers. > +{ > + trace_migrate_send_rp_message((int)cmd, len); > + qemu_mutex_lock(&mis->rp_mutex); > + qemu_put_be16(mis->return_path, (unsigned int)cmd); > + qemu_put_be16(mis->return_path, len); > + qemu_put_buffer(mis->return_path, data, len); > + qemu_fflush(mis->return_path); > + qemu_mutex_unlock(&mis->rp_mutex); > +} > + > +/* > + * Send a 'SHUT' message on the return channel with the given value > + * to indicate that we've finished with the RP. None-0 value indicates > + * error. > + */ > +void migrate_send_rp_shut(MigrationIncomingState *mis, > + uint32_t value) > +{ > + uint32_t buf; > + > + buf =3D cpu_to_be32(value); > + migrate_send_rp_message(mis, MIG_RP_CMD_SHUT, 4, (uint8_t *)&buf); ^ sizeof(buf) would be safer > +} > + > +/* > + * Send a 'PONG' message on the return channel with the given value > + * (normally in response to a 'PING') > + */ > +void migrate_send_rp_pong(MigrationIncomingState *mis, > + uint32_t value) > +{ > + uint32_t buf; > + > + buf =3D cpu_to_be32(value); > + migrate_send_rp_message(mis, MIG_RP_CMD_PONG, 4, (uint8_t *)&buf); It occurs to me that you could define PONG as returning the whole buffer that PING sends, instead of just 4-bytes. Might allow for some more testing of variable sized messages. > +} > + > void qemu_start_incoming_migration(const char *uri, Error **errp) > { > const char *p; > diff --git a/savevm.c b/savevm.c > index d082738..7084d07 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -1008,7 +1008,7 @@ static int loadvm_process_command(QEMUFile *f) > tmp32); > return -1; > } > - /* migrate_send_rp_pong(mis, tmp32); TODO: gets added later */ > + migrate_send_rp_pong(mis, tmp32); > break; > =20 > default: > diff --git a/trace-events b/trace-events > index 99e00b5..4f3eff8 100644 > --- a/trace-events > +++ b/trace-events > @@ -1379,6 +1379,7 @@ migrate_fd_cleanup(void) "" > migrate_fd_error(void) "" > migrate_fd_cancel(void) "" > migrate_pending(uint64_t size, uint64_t max) "pending size %" PRIu64 " m= ax %" PRIu64 > +migrate_send_rp_message(int cmd, uint16_t len) "cmd=3D%d, len=3D%d" > migrate_transferred(uint64_t tranferred, uint64_t time_spent, double ban= dwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " band= width %g max_size %" PRId64 > =20 > # migration/rdma.c --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6zdv2QT/q3FMhpsV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU/oVtAAoJEGw4ysog2bOSZZoP/2qRljNJ40vQI34xExJIiVHE R4JmTpEaVaNsvTlzIR8NRg8iOp+St9Kpn1lTe+BwDCSc088kOKDxagF2jC8oFc+J JgIB3Mt2Z9hjRKsj7zGxh0KzC73V/guMmNrpCLzyWKlGrOe+ohfXfdBF5VyJ4Egj eGKYdF3hmjM2yDSDwjeOf9nWHK1tOBAOIQ9+IXH+jylzgAh5qCEYY5i1KrnQ0amm ICjnl5jpI1+DqcqRzgDM5z6/VqtdhQITP8S+fpBOVmMh+rlHV3hf6uQGcl2uDaNo AsjbyNC/iH+Yk/WYpAJM20w1r4SpGw40QAluprPc9cB5b+GQPOZkXr4TkFiYHeAI AMSAvddf6hz/C+eIUq/VDNZBUMp1hOrl5sijP1mqSTXbfyj0dMJk5RKpSH7+g2Pg ogDJ31rcfLCJugKv11+D4RyoGF+co9UxASdZtzbCLsqXKKfXjswqY4sBUfmt/IFg WBMkYQR73tiCuC766HnSsAne4R8QP5m7Qwb39US7hY/ddCh/Rib9aJtilBuuJMws Fh0MK/IYCYAmjA+s4oV9lmh2bnO4t0NjfN3+AQzUKKiEoybJpjgEf7fgbE3he9dO KTgkrP675aLg5keDFyPwbUs31TVe4l0zsiR/Sk2seRS/2MD8RIYpiRafhalcZG7F xxsZ3qnJT5a7eMSlUcOW =XtqY -----END PGP SIGNATURE----- --6zdv2QT/q3FMhpsV--