From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVMuw-0000dZ-SE for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVMus-00042z-1R for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:22:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVMur-00042q-Qg for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:21:57 -0400 Date: Tue, 10 Mar 2015 16:21:44 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150310162144.GK2338@work-vm> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-4-git-send-email-dgilbert@redhat.com> <54FF0E27.60303@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FF0E27.60303@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 03/45] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com, david@gibson.dropbear.id.au * Eric Blake (eblake@redhat.com) wrote: > On 02/25/2015 09:51 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > check the return value of the function it calls and error if it's non-0 > > Fixup qemu_rdma_init_one_block that is the only current caller, > > and __qemu_rdma_add_block the only function it calls using it. > > Should we also be changing the name of __qemu_rdma_add_block to get rid > of the wrong use of the reserved leading __ namespace? I already did that in ba795761857082a9bb8c4be1f28e7cdd82f039b0 that got merged after I cut this patch. Dave > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK