Re: [PATCH 2/4] ARM: gpio: tegra: Maintain endianness

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Fri, Jan 09, 2015 at 03:27:09PM +0000, Bob Mottram wrote:
> Replace the _raw-writel with writel_relaxed to fix issue with
> running tegra in big-endian. Tested on Jetson TK1.
> 
> Signed-off-by: Bob Mottram <bob.mottram-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> ---
>  drivers/gpio/gpio-tegra.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Linus, Alex,

would you prefer to take this through the GPIO tree or shall I take it
into the Tegra tree along with the rest of this series. In case of the
former:

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

I see that the patch wasn't Cc'ed to linux-gpio or Linus so, for
reference, here's a link to it in patchwork:

	http://patchwork.ozlabs.org/patch/427142/

I'm also quoting the entire patch below for your reference.

Thierry

> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 1741981..a83e140 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -85,12 +85,12 @@ static struct tegra_gpio_bank *tegra_gpio_banks;
> 
>  static inline void tegra_gpio_writel(u32 val, u32 reg)
>  {
> -	__raw_writel(val, regs + reg);
> +	writel_relaxed(val, regs + reg);
>  }
> 
>  static inline u32 tegra_gpio_readl(u32 reg)
>  {
> -	return __raw_readl(regs + reg);
> +	return readl_relaxed(regs + reg);
>  }
> 
>  static int tegra_gpio_compose(int bank, int port, int bit)
> --
> 2.1.0

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]