From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbbCUHXA (ORCPT ); Sat, 21 Mar 2015 03:23:00 -0400 Received: from mail-db3on0144.outbound.protection.outlook.com ([157.55.234.144]:15437 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751132AbbCUHW6 (ORCPT ); Sat, 21 Mar 2015 03:22:58 -0400 X-Greylist: delayed 850 seconds by postgrey-1.27 at vger.kernel.org; Sat, 21 Mar 2015 03:22:57 EDT Date: Sat, 21 Mar 2015 16:08:00 +0900 From: Hyong-Youb Kim To: "Luis R. Rodriguez" CC: , , , , , , , , , , , , , , "Luis R. Rodriguez" , Ingo Molnar , Daniel Vetter , Hyong-Youb Kim , , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Message-ID: <20150321070759.GB8766@gtest01.arcus> References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Originating-IP: [111.91.137.40] X-ClientProxiedBy: HKXPR06CA004.apcprd06.prod.outlook.com (10.242.96.44) To DB4PR05MB318.eurprd05.prod.outlook.com (10.242.192.13) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hyong-youb.kim@cspi.com; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB318; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(51704005)(46406003)(97756001)(66066001)(33656002)(64706001)(23726002)(2950100001)(47776003)(92566002)(87976001)(42186005)(77156002)(77096005)(110136001)(19580395003)(19580405001)(62966003)(50986999)(76176999)(83506001)(50466002)(122386002)(46102003)(40100003)(54356999)(7099025);DIR:OUT;SFP:1102;SCL:1;SRVR:DB4PR05MB318;H:gtest01.arcus;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:DB4PR05MB318;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB318; X-Forefront-PRVS: 05220145DE X-OriginatorOrg: cspi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2015 07:08:33.9650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR05MB318 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. > [...] > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c [...] > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > data[i] = ((u64 *)&link_stats)[i]; > > data[i++] = (unsigned int)mgp->tx_boundary; > - data[i++] = (unsigned int)mgp->wc_enabled; > data[i++] = (unsigned int)mgp->pdev->irq; > data[i++] = (unsigned int)mgp->msi_enabled; > data[i++] = (unsigned int)mgp->msix_enabled; You would have to delete "WC from myri10ge_gstrings_main_stats too. Something like below. Thanks. @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", "tx_heartbeat_errors", "tx_window_errors", /* device-specific stats */ - "tx_boundary", "WC", "irq", "MSI", "MSIX", + "tx_boundary", "irq", "MSI", "MSIX", "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", "serial_number", "watchdog_resets", #ifdef CONFIG_MYRI10GE_DCA From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hyong-Youb Kim Date: Sat, 21 Mar 2015 07:08:00 +0000 Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Message-Id: <20150321070759.GB8766@gtest01.arcus> List-Id: References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, jgross@suse.com, JBeulich@suse.com, bp@suse.de, suresh.b.siddha@intel.com, venkatesh.pallipadi@intel.com, airlied@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, "Luis R. Rodriguez" , Ingo Molnar , Daniel Vetter , Hyong-Youb Kim , netdev@vger.kernel.org, Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. > [...] > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c [...] > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > data[i] = ((u64 *)&link_stats)[i]; > > data[i++] = (unsigned int)mgp->tx_boundary; > - data[i++] = (unsigned int)mgp->wc_enabled; > data[i++] = (unsigned int)mgp->pdev->irq; > data[i++] = (unsigned int)mgp->msi_enabled; > data[i++] = (unsigned int)mgp->msix_enabled; You would have to delete "WC from myri10ge_gstrings_main_stats too. Something like below. Thanks. @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", "tx_heartbeat_errors", "tx_window_errors", /* device-specific stats */ - "tx_boundary", "WC", "irq", "MSI", "MSIX", + "tx_boundary", "irq", "MSI", "MSIX", "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", "serial_number", "watchdog_resets", #ifdef CONFIG_MYRI10GE_DCA