All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
	David Kershner <david.kershner@unisys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, sparmaintainer@unisys.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] staging: unisys: use local variable instead of global
Date: Tue, 24 Mar 2015 15:58:27 +0300	[thread overview]
Message-ID: <20150324125827.GT10964@mwanda> (raw)
In-Reply-To: <1427199457-11771-3-git-send-email-sudipm.mukherjee@gmail.com>

I don't like how these are broken up at all.  It's random grab bag of
renaming and deleting.

Do it like this, perhaps:

[patch 1] delete registered

Leave the if (MAJOR(majordev) >= 0) for now, because it just
confuses issues to mix it in.  Delete all references to registered.

[patch 1] use local variable in visorchipset_file_init()
Don't delete anything.

[patch 2] pass major_dev to visorchipset_file_cleanup()

This deletes the "if (MAJOR(majordev) >= 0)" condition because it's
obvious that can't be true.  This deletes all references to the
"majordev" global because that isn't needed any more.  The whole reason
it was needed originally was because of visorchipset_file_cleanup() so
it's wrong to do the deleting in this patch which is about
visorchipset_file_init().

regards,
dan carpenter


  reply	other threads:[~2015-03-24 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 12:17 [PATCH v4 1/4] staging: unisys: remove unneeded comparison Sudip Mukherjee
2015-03-24 12:17 ` [PATCH v4 2/4] staging: unisys: use local dev_t instead of global Sudip Mukherjee
2015-03-24 12:17 ` [PATCH v4 3/4] staging: unisys: use local variable " Sudip Mukherjee
2015-03-24 12:58   ` Dan Carpenter [this message]
2015-03-24 12:17 ` [PATCH v4 4/4] staging: unisys: remove unused variable Sudip Mukherjee
2015-03-24 12:30 ` [PATCH v4 1/4] staging: unisys: remove unneeded comparison Dan Carpenter
2015-03-24 12:36   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324125827.GT10964@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.