Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Boaz Harrosh <boaz@plexistor.com>, Christoph Hellwig <hch@lst.de>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload
Date: Thu, 2 Apr 2015 18:44:31 +0200	[thread overview]
Message-ID: <20150402164431.GB9774@lst.de> (raw)
In-Reply-To: <CAPcyv4isuVk36ZihTRg1jhiWnXhJvSdD3b_tesxc-srTHD9h9w@mail.gmail.com>

On Thu, Apr 02, 2015 at 09:01:14AM -0700, Dan Williams wrote:
> >> If anything I think these should be dev_dbg().
> >
> > We do not have a dev at any of this point, and it does not
> > belong to any specific device.
> 
> Ah, true this is prior to the driver attaching... that said it seems
> more relevant to print from probe() (where we do have a device) than
> init where the device may remain idle due to some other policy.
> 
> > Also I would like this
> > _info and not _dbg so to always have it, also for production.
> > See the chatter for a single SCSI disk the minimum we need
> > is just the small print that tells all that we need (for now)
> 
> Not sure we want to follow so closely in the footsteps of SCSI's chattiness.

Defintively not!  A single dev_info at ->probe time sounds ok, something
like:

	dev_info(dev, "registering region [0x%pa:0x%zx]\n",
			&pmem->phys_addr, pmem->size);

but there are plenty other drivers not that chatty, e.g. virtio and we're
doing just fine for them.