All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCHv2] libsas: Fixup transport protocol definition in sas_get_ata_info()
Date: Tue, 7 Apr 2015 17:45:50 +0200	[thread overview]
Message-ID: <20150407154550.GA18837@lst.de> (raw)
In-Reply-To: <1428396547-87814-1-git-send-email-hare@suse.de>

On Tue, Apr 07, 2015 at 10:49:07AM +0200, Hannes Reinecke wrote:
> 'tproto' specifies the transport protocol, not the device type.
> So use the correct definitions here.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>

This looks correct, but opens up questions:

 - how did you find this?
 - why didn't we notice earlier?

Also I wonder if we should move to more __bitwise types for these
kinds of things..

  reply	other threads:[~2015-04-07 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  8:49 [PATCHv2] libsas: Fixup transport protocol definition in sas_get_ata_info() Hannes Reinecke
2015-04-07 15:45 ` Christoph Hellwig [this message]
2015-04-07 15:59   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407154550.GA18837@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.