From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965405AbbD0UgQ (ORCPT ); Mon, 27 Apr 2015 16:36:16 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59028 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965078AbbD0UgM (ORCPT ); Mon, 27 Apr 2015 16:36:12 -0400 Date: Mon, 27 Apr 2015 22:36:08 +0200 From: Pavel Machek To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Stephen Warren , Mikko Perttunen , kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/13] thermal: Make temperatures consistently unsigned long Message-ID: <20150427203608.GD29351@xo-6d-61-c0.localdomain> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2015-03-26 16:53:48, Sascha Hauer wrote: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell. Maybe millicelsius_t should be introduced, so that readers immediately know what type it is? Some parts of kernel also use decicelsius and decikelvin, IIRC (ACPI). Pavel > if (trip_type == THERMAL_TRIP_CRITICAL) { > dev_emerg(&tz->device, > - "critical temperature reached(%d C),shutting down\n", > + "critical temperature reached(%lu C),shutting down\n", space after , ? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Mon, 27 Apr 2015 22:36:08 +0200 Subject: [PATCH 01/13] thermal: Make temperatures consistently unsigned long In-Reply-To: <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> Message-ID: <20150427203608.GD29351@xo-6d-61-c0.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu 2015-03-26 16:53:48, Sascha Hauer wrote: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell. Maybe millicelsius_t should be introduced, so that readers immediately know what type it is? Some parts of kernel also use decicelsius and decikelvin, IIRC (ACPI). Pavel > if (trip_type == THERMAL_TRIP_CRITICAL) { > dev_emerg(&tz->device, > - "critical temperature reached(%d C),shutting down\n", > + "critical temperature reached(%lu C),shutting down\n", space after , ? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html