All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+
Date: Thu, 7 May 2015 10:08:14 -0400	[thread overview]
Message-ID: <20150507140814.GF27106@fieldses.org> (raw)
In-Reply-To: <20150507075302.GA23816@lst.de>

On Thu, May 07, 2015 at 09:53:02AM +0200, Christoph Hellwig wrote:
> On Wed, May 06, 2015 at 12:12:13PM +0200, Andreas Grünbacher wrote:
> > 2015-05-06 8:56 GMT+02:00 Christoph Hellwig <hch@lst.de>:
> > > How about moving the workaround into the NFSv2 specific code?
> > 
> > Not trivially, we would have to fh_verify() the file handle in
> > nfsd_proc_setattr() first. Is that preferable?
> 
> Sounds better to me than making this workaround even more invasive
> in the core.  Bruce, what do you think?

I haven't looked into it, but I certainly don't see a reason why an
extra call to nfsd_proc_setattr would be a problem.  And I agree that it
would be nice to have this in NFSv2-specific code.

--b.

  reply	other threads:[~2015-05-07 14:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  6:50 [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+ Andreas Gruenbacher
2015-05-06  6:56 ` Christoph Hellwig
2015-05-06 10:12   ` Andreas Grünbacher
2015-05-07  7:53     ` Christoph Hellwig
2015-05-07 14:08       ` J. Bruce Fields [this message]
2015-05-08 22:37         ` [PATCH v2] " Andreas Gruenbacher
2015-05-08 22:50           ` Andreas Grünbacher
2015-05-11 12:27             ` Christoph Hellwig
2015-05-12 18:38               ` Andreas Grünbacher
2015-05-11 12:26           ` Christoph Hellwig
2015-05-12 19:17             ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150507140814.GF27106@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=andreas.gruenbacher@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.