From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys8Ej-0006nF-Bw
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:20:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys8Ef-00056J-23
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:20:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45355)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys8Ee-00056D-Q7
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:20:28 -0400
Date: Tue, 12 May 2015 12:20:19 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150512112019.GI18200@redhat.com>
References: <00c901d08990$2763c410$762b4c30$@samsung.com>
	<20150512092015.GF18200@redhat.com>
	<CAFEAcA_Hi7H1U0W287JCoZRsB9fV4x9rAm2gYCGyzGsQsOtE9Q@mail.gmail.com>
	<039401d08ca4$ff1cd830$fd568890$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <039401d08ca4$ff1cd830$fd568890$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'QEMU Developers' <qemu-devel@nongnu.org>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

On Tue, May 12, 2015 at 02:15:46PM +0300, Pavel Fedin wrote:
>  Hello!
> 
> > We are not. Support for GICv2 vs v3 should be dealt with
> > by suitable machine properties
> 
>  I don't remember whether i clearly wrote about it... First i added a
> property, like -machine virt,gicv3=on. But then i decided to stick back
> to different machine name because libvirt does not have mechanism for
> passing machine options.

Actually there was a enhancement done to libvirt a week or two ago to
support enablment of the GIC and choice of versions.

<domain type='kvm'>
  ....
  <features>
     <gic version='3'/>
  </features>
  ...
</domain>

commit 921c52b0db3ac898d5cc4eda19fb861ad58d9a9e
Author: Michal Privoznik <mprivozn@redhat.com>
Date:   Mon Apr 27 14:03:19 2015 +0200

    Introduce GIC feature
    
    Some platforms, like aarch64, don't have APIC but GIC. So there's
    no reason to have <apic/> feature turned on. However, we are
    still missing <gic/> feature. This commit introduces the feature
    to XML parser and formatter, adds documentation and updates RNG
    schema.
    
    Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|