From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934428AbbEMNuL (ORCPT ); Wed, 13 May 2015 09:50:11 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:35467 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933767AbbEMNuE (ORCPT ); Wed, 13 May 2015 09:50:04 -0400 Date: Wed, 13 May 2015 09:50:00 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, richard@nod.at, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , cgroups@vger.kernel.org, mingo@redhat.com, Peter Zijlstra Subject: Re: [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys Message-ID: <20150513135000.GP11388@htj.duckdns.org> References: <1429446154-10660-1-git-send-email-cyphar@cyphar.com> <1429446154-10660-2-git-send-email-cyphar@cyphar.com> <20150422152551.GA10738@htj.duckdns.org> <20150422154212.GE3007@worktop.Skamania.guest> <20150422160258.GE10738@htj.duckdns.org> <20150426160909.GC1499@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Aleksa. On Wed, May 13, 2015 at 03:44:51PM +1000, Aleksa Sarai wrote: > I think I'll just do casting and manually make new variables where > required. The above (and similar) doesn't work very well, generates > warnings like crazy and breaks stuff like: > > if (...) > for_each_subsys_which(...) Ah, right, and we can't wrap the declaration in a new block. I'm okay with converting ss_masks to unsigned longs if necessary. Just do a wholesale conversion. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys Date: Wed, 13 May 2015 09:50:00 -0400 Message-ID: <20150513135000.GP11388@htj.duckdns.org> References: <1429446154-10660-1-git-send-email-cyphar@cyphar.com> <1429446154-10660-2-git-send-email-cyphar@cyphar.com> <20150422152551.GA10738@htj.duckdns.org> <20150422154212.GE3007@worktop.Skamania.guest> <20150422160258.GE10738@htj.duckdns.org> <20150426160909.GC1499@htj.duckdns.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=NFDSs8CjUOMsGoYP42zs6jl8wvWS/53nnysFH4HCYoQ=; b=qGBMAIQBSeE0Bw05tQ8s+nJdcEMkRdUZrJVf85TxYi7ts2JymWK9CAFk7DaL4aHGJT HTTgWLKe4YEBgF8sm/lLqx6kk91aVv8DE0FnnzsLDvPGwu8BY8k6xOXAtXvPa/YoOnAj DGImk+ldF8DSayi5gFB6Evxwdo8qtU3rzjOGRld2Q3DqgQqmrB6Mqob6ZGkAjYxtHtSP l+vIJDow+wijls4sYCeNVe7FcykVZIiT+AaX7g8a5IEfOrxLWf2tsJPf6bDNa++uo5oA 3Gav1ZM66gh+1v5+WCfALtF3qo670U4IAYy9cF6KMmNUw192fkK2jkxbLGq139yd4lG/ wXXA== Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Aleksa Sarai Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Peter Zijlstra Hello, Aleksa. On Wed, May 13, 2015 at 03:44:51PM +1000, Aleksa Sarai wrote: > I think I'll just do casting and manually make new variables where > required. The above (and similar) doesn't work very well, generates > warnings like crazy and breaks stuff like: > > if (...) > for_each_subsys_which(...) Ah, right, and we can't wrap the declaration in a new block. I'm okay with converting ss_masks to unsigned longs if necessary. Just do a wholesale conversion. Thanks. -- tejun