From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ysto3-0005T4-7m for qemu-devel@nongnu.org; Thu, 14 May 2015 10:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ystny-0000Xc-9B for qemu-devel@nongnu.org; Thu, 14 May 2015 10:08:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ystny-0000Wn-1G for qemu-devel@nongnu.org; Thu, 14 May 2015 10:08:06 -0400 Date: Thu, 14 May 2015 16:07:55 +0200 From: "Michael S. Tsirkin" Message-ID: <20150514160545-mutt-send-email-mst@redhat.com> References: <20150513174204.GS23627@redhat.com> <5553C651.4060000@redhat.com> <20150514111825.GE3441@redhat.com> <878ucr4bb7.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878ucr4bb7.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, pbonzini@redhat.com, John Snow , rth@twiddle.net On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: > Correct. > > Here's how I think it should be done: > > * Create a machine option to control the FDC > > This is a machine-specific option. It should only exist for machine > types that have an optional FDC. > > Default must be "on" for old machine types. Default may be "off" for > new machine types. > > It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards > commonly don't have an FDC (depends on the Super I/O chip used). > > We may want to keep it off for pc-i440fx-2.4 and newer. I doubt > there's a real i440FX without an FDC, but our virtual i440FX is quite > unlike a real one in other ways already. I think making it off by default is a bad idea, it will break command-line users. > * Create the FDC only if the option is "on". > > * Optional: make -drive if=floppy,... auto-enable it Every time we do such auto hacks, we regret this later. Just do what we are told, fail if=floppy if disabled. > I wouldn't bother doing the same for -global isa-fdc.driveA=... and > such. > > Stefano, if you're willing to tackle this, go right ahead! From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] Do not emulate a floppy drive when -nodefaults Date: Thu, 14 May 2015 16:07:55 +0200 Message-ID: <20150514160545-mutt-send-email-mst@redhat.com> References: <20150513174204.GS23627@redhat.com> <5553C651.4060000@redhat.com> <20150514111825.GE3441@redhat.com> <878ucr4bb7.fsf@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <878ucr4bb7.fsf@blackfin.pond.sub.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Markus Armbruster Cc: Kevin Wolf , xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, pbonzini@redhat.com, John Snow , rth@twiddle.net List-Id: xen-devel@lists.xenproject.org On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: > Correct. > > Here's how I think it should be done: > > * Create a machine option to control the FDC > > This is a machine-specific option. It should only exist for machine > types that have an optional FDC. > > Default must be "on" for old machine types. Default may be "off" for > new machine types. > > It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards > commonly don't have an FDC (depends on the Super I/O chip used). > > We may want to keep it off for pc-i440fx-2.4 and newer. I doubt > there's a real i440FX without an FDC, but our virtual i440FX is quite > unlike a real one in other ways already. I think making it off by default is a bad idea, it will break command-line users. > * Create the FDC only if the option is "on". > > * Optional: make -drive if=floppy,... auto-enable it Every time we do such auto hacks, we regret this later. Just do what we are told, fail if=floppy if disabled. > I wouldn't bother doing the same for -global isa-fdc.driveA=... and > such. > > Stefano, if you're willing to tackle this, go right ahead!