From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZKNvZ-0007vW-I0
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZKNvW-0003H8-O8
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:33 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:53803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZKNvW-0003Gv-GO
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:30 -0400
Date: Wed, 29 Jul 2015 11:45:12 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20150729094512.GH2979@type.bordeaux.inria.fr>
References: <20150728225701.GK3467@type.home> <55B8831A.6090707@siemens.com>
	<20150729074710.GZ3467@type.home> <55B887AC.9020109@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55B887AC.9020109@siemens.com>
Subject: Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu
	-net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Vasiliy Tolstov <v.tolstov@selfip.ru>, peter.huangpeng@huawei.com, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Dave Gilbert <dgilbert@redhat.com>

Jan Kiszka, le Wed 29 Jul 2015 09:58:36 +0200, a écrit :
> On 2015-07-29 09:47, Samuel Thibault wrote:
> > Ok. Two of the patches are however from a different author, I haven't
> > found how to specify different From addresses with git send-email.
> 
> This knowledge is buried in scripts here, but IIRC it should suffice
> having recorded authorship correctly in git.

Ok.

> >> Also, some are signed-off by you, others not. As a maintainer, you
> >> should sign all of them. Or is there a particular reason (not yet
> >> reviewed etc.)?
> > 
> > The reason was just that I hadn't touched those patches at all, but I
> > reviewed them all.
> 
> If you touch a patch and it's just trivial, add a simple changelog like
> 
> Signed-off-by: Author ....
> [Samuel: fix minor style issue etc.]
> Signed-off-by: You

Well, I have to say I really don't remember what I changed myself, since
that was more than 2 years ago already.  I'd have to go through the
whole git log to find the information.

> If you change the patch significantly, rather remove the authors
> signed-off and ask to provide it again for the modified version.

He had reviewed the changes, and was OK with them.

I have put the series on http://dept-info.labri.fr/~thibault/qemu-ipv6
in the tosubmit branch.

Samuel