Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers

From: Peter Krempa <pkrempa@redhat.com>
To: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
	deepakcs@redhat.com, bharata@linux.vnet.ibm.com,
	rtalur@redhat.com
Subject: Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers
Date: Thu, 22 Oct 2015 09:03:07 +0200	[thread overview]
Message-ID: <20151022070307.GA5667@andariel.pipo.sk> (raw)
In-Reply-To: <1445434451-3439-3-git-send-email-prasanna.kalever@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Wed, Oct 21, 2015 at 19:04:11 +0530, Prasanna Kumar Kalever wrote:

...

> ---
>  block/gluster.c      | 420 +++++++++++++++++++++++++++++++++++++++++++++------
>  qapi/block-core.json |  62 +++++++-
>  2 files changed, 433 insertions(+), 49 deletions(-)
> 
> diff --git a/block/gluster.c b/block/gluster.c
> index ededda2..62b6656 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c

...

> +
>  
>  static void qemu_gluster_gconf_free(GlusterConf *gconf)
>  {
>      if (gconf) {
> -        g_free(gconf->host);
>          g_free(gconf->volume);
>          g_free(gconf->path);
> -        g_free(gconf->transport);
> +        if (gconf->gsconf) {
> +            g_free(gconf->gsconf[0].host);
> +            g_free(gconf->gsconf[0].transport);
> +            g_free(gconf->gsconf);

Looks like this leaks second and any further server config struct.

> +        }
>          g_free(gconf);
>      }
>  }

Peter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]