From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuFP0-0001br-9N for qemu-devel@nongnu.org; Thu, 05 Nov 2015 02:56:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuFOx-0004Qm-3B for qemu-devel@nongnu.org; Thu, 05 Nov 2015 02:56:10 -0500 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:42769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuFOw-0004QJ-Qh for qemu-devel@nongnu.org; Thu, 05 Nov 2015 02:56:07 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Nov 2015 07:56:05 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4F9091B08075 for ; Thu, 5 Nov 2015 07:56:17 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA57u24U40632390 for ; Thu, 5 Nov 2015 07:56:02 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA57u2Tw028857 for ; Thu, 5 Nov 2015 00:56:02 -0700 Date: Thu, 5 Nov 2015 08:55:58 +0100 From: Greg Kurz Message-ID: <20151105085558.31d3a8f3@bahia.local> In-Reply-To: <1446657582-21619-3-git-send-email-den@openvz.org> References: <1446657582-21619-1-git-send-email-den@openvz.org> <1446657582-21619-3-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela On Wed, 4 Nov 2015 20:19:33 +0300 "Denis V. Lunev" wrote: > this will make code better in the next patch > This changelog is not very useful. IMHO this calls for squashing this patch into the next one: then we clearly see how the return value is used and why the code is better. > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > block/snapshot.c | 7 ++++--- > include/block/snapshot.h | 6 +++--- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/block/snapshot.c b/block/snapshot.c > index 2ef4545..d729c76 100644 > --- a/block/snapshot.c > +++ b/block/snapshot.c > @@ -253,9 +253,9 @@ int bdrv_snapshot_delete(BlockDriverState *bs, > return -ENOTSUP; > } > > -void bdrv_snapshot_delete_by_id_or_name(BlockDriverState *bs, > - const char *id_or_name, > - Error **errp) > +int bdrv_snapshot_delete_by_id_or_name(BlockDriverState *bs, > + const char *id_or_name, > + Error **errp) > { > int ret; > Error *local_err = NULL; > @@ -270,6 +270,7 @@ void bdrv_snapshot_delete_by_id_or_name(BlockDriverState *bs, > if (ret < 0) { > error_propagate(errp, local_err); > } > + return ret; > } > > int bdrv_snapshot_list(BlockDriverState *bs, > diff --git a/include/block/snapshot.h b/include/block/snapshot.h > index 0a3cf0d..76cf6a3 100644 > --- a/include/block/snapshot.h > +++ b/include/block/snapshot.h > @@ -63,9 +63,9 @@ int bdrv_snapshot_delete(BlockDriverState *bs, > const char *snapshot_id, > const char *name, > Error **errp); > -void bdrv_snapshot_delete_by_id_or_name(BlockDriverState *bs, > - const char *id_or_name, > - Error **errp); > +int bdrv_snapshot_delete_by_id_or_name(BlockDriverState *bs, > + const char *id_or_name, > + Error **errp); > int bdrv_snapshot_list(BlockDriverState *bs, > QEMUSnapshotInfo **psn_info); > int bdrv_snapshot_load_tmp(BlockDriverState *bs,