From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ben@decadent.org.uk, hannes@cmpxchg.org, vdavydov@virtuozzo.com,
linux-mm@kvack.org
Subject: Re: + memcg-fix-thresholds-for-32b-architectures-fix-fix.patch added to -mm tree
Date: Fri, 6 Nov 2015 10:52:08 +0100 [thread overview]
Message-ID: <20151106095208.GD4390@dhcp22.suse.cz> (raw)
In-Reply-To: <20151105183132.0a5f874c7f5f69b3c2e53dd1@linux-foundation.org>
On Thu 05-11-15 18:31:32, Andrew Morton wrote:
> On Wed, 4 Nov 2015 10:18:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Tue 03-11-15 15:32:11, Andrew Morton wrote:
> > > From: Andrew Morton <akpm@linux-foundation.org>
> > > Subject: memcg-fix-thresholds-for-32b-architectures-fix-fix
> > >
> > > don't attempt to inline mem_cgroup_usage()
> > >
> > > The compiler ignores the inline anwyay. And __always_inlining it adds 600
> > > bytes of goop to the .o file.
> >
> > I am not sure you whether you want to fold this into the original patch
> > but I would prefer this to be a separate one.
>
> I'm going to drop this - it was already marked inline and gcc just
> ignores the inline anyway so shrug.
gcc version 5.2.1 20151010 (Debian 5.2.1-22)
$ size mm/memcontrol.o mm/memcontrol.o.before
text data bss dec hex filename
35535 7908 64 43507 a9f3 mm/memcontrol.o
35762 7908 64 43734 aad6 mm/memcontrol.o.before
So it's only 227B but still. I think it is worth it.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-06 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 23:32 + memcg-fix-thresholds-for-32b-architectures-fix-fix.patch added to -mm tree akpm
2015-11-04 9:18 ` Michal Hocko
2015-11-06 2:31 ` Andrew Morton
2015-11-06 9:52 ` Michal Hocko [this message]
2015-11-07 14:23 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106095208.GD4390@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.