From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuhSZ-0004Lc-IY for qemu-devel@nongnu.org; Fri, 06 Nov 2015 08:53:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuhSW-0003U8-CT for qemu-devel@nongnu.org; Fri, 06 Nov 2015 08:53:43 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:35462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuhSW-0003Tr-4q for qemu-devel@nongnu.org; Fri, 06 Nov 2015 08:53:40 -0500 Received: by wmll128 with SMTP id l128so35562563wml.0 for ; Fri, 06 Nov 2015 05:53:39 -0800 (PST) Date: Fri, 6 Nov 2015 13:53:37 +0000 From: Stefan Hajnoczi Message-ID: <20151106135337.GM12285@stefanha-x1.localdomain> References: <1446657582-21619-1-git-send-email-den@openvz.org> <1446657582-21619-2-git-send-email-den@openvz.org> <20151105072650.6c35f118@bahia.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aiCxlS1GuupXjEh3" Content-Disposition: inline In-Reply-To: <20151105072650.6c35f118@bahia.local> Subject: Re: [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Kevin Wolf , "Denis V. Lunev" , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela --aiCxlS1GuupXjEh3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 05, 2015 at 07:26:50AM +0100, Greg Kurz wrote: > On Wed, 4 Nov 2015 20:19:32 +0300 > > + * > > + * Returned block driver will be always locked. > > + */ > > + > > +bool bdrv_all_can_snapshot(BlockDriverState **first_bad_bs) >=20 > Juan suggested bdrv_snapshot_is_possible() and FWIW you already emphasize > that it involves all block drivers in the above comment. I like the "all" in the function name. There is a set of bdrv_*_all() functions that operate on all BlockDriverStates. What these functions have in common is that they acquire AioContext. Other bdrv_*() functions don't do this, so the naming helps make the semantics clear. --aiCxlS1GuupXjEh3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWPLDhAAoJEJykq7OBq3PIYbMIAJIbcQzFObZhzV8zeUVScV/6 k7h/v0tPXzKQXl0lTueUJU7fDoXPedzMlLYt64/iYH8hBjhUH9OiUqwY1Tncjjvp omWArRPOGH/wz6LwfOxF+7pTNRdc3EKNktropZ2Sv0w9Uajg8o64+SbVPs+FwGaS /T6m/d1Bk4r+868ey4NQ8+Qotzz/b94KR+n/GQg/XjdGZAw8kxYT4/ZopBSQzR20 tVzwOLLejWtH9TFZCmJz6uqU5EQqd44pDcmIdUn9A94w7QAexBNeV9WwU5JMj/e3 Ne3sQOPivHbT0CD+0qeRpTKZXsZnZLPCH6Z4BF5v1+by57VEtFCTYU2xnyfE+gw= =a/av -----END PGP SIGNATURE----- --aiCxlS1GuupXjEh3--