From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from op Date: Sat, 7 Nov 2015 02:19:32 -0800 Message-ID: <20151107101932.GC12117@infradead.org> References: <1446674909-5371-1-git-send-email-mchristi@redhat.com> <1446674909-5371-20-git-send-email-mchristi@redhat.com> <563A8A33.3000002@sandisk.com> <563B930F.7040705@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <563B930F.7040705-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Mike Christie Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, device-mapper development , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: linux-raid.ids On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote: > I can do that. You are right in how they are used. I just did the above, > to follow the other *_data_dir calls. I think the *_data_dir calls are horrible interfaces. But your series already is huge, so if it makes your life easier I'd say keep it as-is for now. But in the long run we should have the interfaces that Bart suggested, and one that gives you a dma_data_direction from a request, as that's what a lot of the driver ultimatively want. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbbKGKTf (ORCPT ); Sat, 7 Nov 2015 05:19:35 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40934 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbKGKTd (ORCPT ); Sat, 7 Nov 2015 05:19:33 -0500 Date: Sat, 7 Nov 2015 02:19:32 -0800 From: Christoph Hellwig To: Mike Christie Cc: Bart Van Assche , device-mapper development , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from op Message-ID: <20151107101932.GC12117@infradead.org> References: <1446674909-5371-1-git-send-email-mchristi@redhat.com> <1446674909-5371-20-git-send-email-mchristi@redhat.com> <563A8A33.3000002@sandisk.com> <563B930F.7040705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563B930F.7040705@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote: > I can do that. You are right in how they are used. I just did the above, > to follow the other *_data_dir calls. I think the *_data_dir calls are horrible interfaces. But your series already is huge, so if it makes your life easier I'd say keep it as-is for now. But in the long run we should have the interfaces that Bart suggested, and one that gives you a dma_data_direction from a request, as that's what a lot of the driver ultimatively want.