From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 32/32] block: remove __REQ op defs and reduce bi_op/bi_rw sizes Date: Sat, 7 Nov 2015 02:21:47 -0800 Message-ID: <20151107102147.GD12117@infradead.org> References: <1446674909-5371-1-git-send-email-mchristi@redhat.com> <1446674909-5371-33-git-send-email-mchristi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1446674909-5371-33-git-send-email-mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: linux-raid.ids I love this series! Also I think it's very good that we finally split the ioprio out to it's own field. Thanks a lot for doing this work. > I was not sure if or how much or where people wanted to stick things. > There also appears to be room in the bi_flags field. If bi_flags is > only using 13 bits and there are only 16 REQ_XYZs bits related bios, > I could put them all in one variable if we wanted to go wild with trying > to shrink the bio while I am at it.. This sounds interesting, but I'd rather do it as a separate project later. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbbKGKVu (ORCPT ); Sat, 7 Nov 2015 05:21:50 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40955 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbKGKVs (ORCPT ); Sat, 7 Nov 2015 05:21:48 -0500 Date: Sat, 7 Nov 2015 02:21:47 -0800 From: Christoph Hellwig To: mchristi@redhat.com Cc: linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [PATCH 32/32] block: remove __REQ op defs and reduce bi_op/bi_rw sizes Message-ID: <20151107102147.GD12117@infradead.org> References: <1446674909-5371-1-git-send-email-mchristi@redhat.com> <1446674909-5371-33-git-send-email-mchristi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446674909-5371-33-git-send-email-mchristi@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I love this series! Also I think it's very good that we finally split the ioprio out to it's own field. Thanks a lot for doing this work. > I was not sure if or how much or where people wanted to stick things. > There also appears to be room in the bi_flags field. If bi_flags is > only using 13 bits and there are only 16 REQ_XYZs bits related bios, > I could put them all in one variable if we wanted to go wild with trying > to shrink the bio while I am at it.. This sounds interesting, but I'd rather do it as a separate project later.