From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZvdjX-0004Sq-VS
	for qemu-devel@nongnu.org; Sun, 08 Nov 2015 23:07:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZvdjU-0003g0-PR
	for qemu-devel@nongnu.org; Sun, 08 Nov 2015 23:07:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZvdjU-0003fv-Jq
	for qemu-devel@nongnu.org; Sun, 08 Nov 2015 23:07:04 -0500
Date: Mon, 9 Nov 2015 09:36:55 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20151109040655.GA16185@grmbl.mre>
References: <563E16AF.8070209@openvz.org>
	<1446910812-13044-1-git-send-email-den@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446910812-13044-1-git-send-email-den@openvz.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] migration: qemu_savevm_state_cleanup
 becomes mandatory operation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, liang.z.li@intel.com, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

CC'ing Liang Li, author of the patch.

On (Sat) 07 Nov 2015 [18:40:12], Denis V. Lunev wrote:
> since commit
>     commit 94f5a43704129ca4995aa3385303c5ae225bde42
>     Author: Liang Li <liang.z.li@intel.com>
>     Date:   Mon Nov 2 15:37:00 2015 +0800
> 
>     migration: defer migration_end & blk_mig_cleanup
> 
> when actual .cleanup callbacks calling was removed from complete operations.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>
> ---
>  migration/savevm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c
> index e05158d..9f2230f 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -942,8 +942,8 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
>          qemu_savevm_state_complete(f);
>          ret = qemu_file_get_error(f);
>      }
> +    qemu_savevm_state_cleanup();
>      if (ret != 0) {
> -        qemu_savevm_state_cleanup();
>          error_setg_errno(errp, -ret, "Error while writing VM state");
>      }
>      return ret;
> -- 
> 2.5.0
> 

		Amit