All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	Mario Limonciello <mario_limonciello@dell.com>
Subject: Re: [PATCH v2 3/3] dell-wmi: Improve unknown hotkey handling
Date: Fri, 4 Dec 2015 09:39:23 +0100	[thread overview]
Message-ID: <20151204083923.GL10982@pali> (raw)
In-Reply-To: <20151203233856.GC1800@malice.jf.intel.com>

On Thursday 03 December 2015 15:38:56 Darren Hart wrote:
> Pali, this appears to have the one change you asked for (0x%x instead of %d).
> I've added the Reviewed-by: Pali Rohár <pali.rohar@gmail.com> you provided
> previously pending this change.

Ok.

> > +		/* Uninitialized entries are 0 aka KEY_RESERVED. */
> > +		u16 keycode = (bios_entry->keycode <
> > +			       ARRAY_SIZE(bios_to_linux_keycode)) ?
> > +			bios_to_linux_keycode[bios_entry->keycode] :
> > +			KEY_RESERVED;
> > +		BUILD_BUG_ON(KEY_RESERVED != 0);

Anyway, Darren what do you think is that BUILD_BUG_ON check needed?

-- 
Pali Rohár
pali.rohar@gmail.com

  parent reply	other threads:[~2015-12-04  8:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01  1:01 [PATCH v2 0/3] dell platform driver tweaks v2 Andy Lutomirski
2015-12-01  1:01 ` [PATCH v2 1/3] dell-wmi: Use a C99-style array for bios_to_linux_keycode Andy Lutomirski
2015-12-03 23:32   ` Darren Hart
2015-12-03 23:45     ` Andy Lutomirski
2015-12-04  0:07       ` Darren Hart
2015-12-01  1:02 ` [PATCH v2 2/3] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) Andy Lutomirski
2015-12-01 16:38   ` Mario Limonciello
2015-12-03 23:52   ` Darren Hart
2015-12-04  0:00     ` Andy Lutomirski
2015-12-04  9:03   ` Pali Rohár
2015-12-04 16:05     ` Andy Lutomirski
2015-12-01  1:02 ` [PATCH v2 3/3] dell-wmi: Improve unknown hotkey handling Andy Lutomirski
2015-12-03 23:38   ` Darren Hart
2015-12-03 23:45     ` Andy Lutomirski
2015-12-04  0:07       ` Darren Hart
2015-12-04  0:10         ` Andy Lutomirski
2015-12-04  0:21           ` Darren Hart
2015-12-04  8:39     ` Pali Rohár [this message]
2015-12-04 16:15       ` Andy Lutomirski
2015-12-09  0:33         ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204083923.GL10982@pali \
    --to=pali.rohar@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.