From: David Miller <davem@davemloft.net>
To: bkenward@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
dpieczko@solarflare.com
Subject: Re: [PATCH net-next] sfc: check warm_boot_count after other functions have been reset
Date: Sat, 05 Dec 2015 17:59:31 -0500 (EST) [thread overview]
Message-ID: <20151205.175931.170629319560007846.davem@davemloft.net> (raw)
In-Reply-To: <56615367.30002@solarflare.com>
From: Bert Kenward <bkenward@solarflare.com>
Date: Fri, 4 Dec 2015 08:48:39 +0000
> From: Daniel Pieczko <dpieczko@solarflare.com>
>
> A change in MCFW behaviour means that the net driver must update its record
> of the warm_boot_count by reading it from the ER_DZ_BIU_MC_SFT_STATUS
> register.
>
> On v4.6.x MCFW the global boot count was incremented when some functions
> needed to be reset to enable multicast chaining, so all functions saw the
> same value. In that case, the driver needed to increment its
> warm_boot_count when other functions were reset, to avoid noticing it later
> and then trying to reset itself to recover unnecessarily.
>
> With v4.7+ MCFW, the boot count in firmware doesn't change as that is
> unnecessary since the PFs that have been reset will each receive an MC
> reboot notification. In that case, the driver re-reads the unchanged
> value.
>
> Signed-off-by: Bert Kenward <bkenward@solarflare.com>
Applied, thanks.
prev parent reply other threads:[~2015-12-05 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 8:48 [PATCH net-next] sfc: check warm_boot_count after other functions have been reset Bert Kenward
2015-12-05 22:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205.175931.170629319560007846.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bkenward@solarflare.com \
--cc=dpieczko@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.