All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: x86 fpu: command-line parameters broken post-FPU-rewrite
Date: Wed, 9 Dec 2015 20:14:11 +0100	[thread overview]
Message-ID: <20151209191411.GC10475@pd.tnic> (raw)
In-Reply-To: <20151209083209.GB15254@gmail.com>

On Wed, Dec 09, 2015 at 09:32:10AM +0100, Ingo Molnar wrote:
> 
> * Dave Hansen <dave.hansen@intel.com> wrote:
> 
> > Hey Ingo,
> > 
> > We were starting to look at reenabling XSAVES support and tried to use the 
> > 'noxsave' and 'noxsaves' kernel command-line options.  The rewrite moved the FPU 
> > initialization to before we even are parsing command-line options, even the 
> > early_param()s.
> > 
> > Do you have any preferences on how it gets fixed?
> > 
> > The most obvious thing would be to just defer as much of the FPU setup as we can 
> > until after parse_early_param() has happened.  The only other think I can think 
> > of doing would be to try to do some *really* early, simple, command-line parsing 
> > to look for 'noxsave' and friends.
> > 
> > Thoughts?
> 
> Hm, so given that having the FPU operational is key to a functioning kernel (and 
> other kernel subsystems may make use of FPU functionality), I'd rather bring 
> option parsing earlier than change the FPU setup sequence. FPU setup should be 
> done when we identify the CPU - not 'very late' as we used to.

We already have early cmdline parsing: arch/x86/lib/cmdline.c

See users for examples.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

      reply	other threads:[~2015-12-09 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 20:43 x86 fpu: command-line parameters broken post-FPU-rewrite Dave Hansen
2015-12-09  8:32 ` Ingo Molnar
2015-12-09 19:14   ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151209191411.GC10475@pd.tnic \
    --to=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.