From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] [v2] drm/i915: Limit VF cache invalidate workaround usage to gen9
Date: Mon, 21 Dec 2015 13:05:05 +0100 [thread overview]
Message-ID: <20151221120505.GN30437@phenom.ffwll.local> (raw)
In-Reply-To: <1450434856.27869.5.camel@intel.com>
On Fri, Dec 18, 2015 at 12:34:16PM +0200, Imre Deak wrote:
> On pe, 2015-12-18 at 11:59 +0200, Jani Nikula wrote:
> > On Thu, 17 Dec 2015, Imre Deak <imre.deak@intel.com> wrote:
> > > On Thu, 2015-12-17 at 09:49 -0800, Ben Widawsky wrote:
> > > > +> if (IS_GEN9(ring->dev))
> > >
> > > Nitpick: INTEL_INFO()->gen == 9 is the preferred way.
> >
> > Oh? Since when and says who?
>
> Haven't found it after some digging, but I do remember someone having
> this comment earlier.
>
> My opinion is that we should only use one form, and since INTEL_INFO()-
> gen can be used in a more generic manner I would prefer that. Currently
> we have it both ways in the code.
We use IS_GENx for individual gen checks and INTEL_INFO()->gen when
checking for ranges. At least that's the usage I inferred ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-21 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 1:51 [PATCH] drm/i915: Limit VF cache invalidate workaround usage to gen9 Ben Widawsky
2015-12-17 17:49 ` [PATCH] [v2] " Ben Widawsky
2015-12-17 20:49 ` Imre Deak
2015-12-17 21:39 ` Ben Widawsky
2015-12-18 9:59 ` Jani Nikula
2015-12-18 10:34 ` Imre Deak
2015-12-21 12:05 ` Daniel Vetter [this message]
2015-12-21 12:06 ` Daniel Vetter
2015-12-18 7:20 ` ✗ warning: Fi.CI.BAT Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221120505.GN30437@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.widawsky@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.