Re: [PATCH] drm/i915/dsi: add debug printing of the new sequence block names

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Jan 05, 2016 at 05:08:17PM +0200, Jani Nikula wrote:
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> index 70fc11e0869d..a5817bef2d71 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> @@ -307,6 +307,12 @@ static const char * const seq_name[] = {
>  	[MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON",
>  	[MIPI_SEQ_DISPLAY_OFF]  = "MIPI_SEQ_DISPLAY_OFF",
>  	[MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
> +	[MIPI_SEQ_BACKLIGHT_ON] = "MIPI_SEQ_BACKLIGHT_ON",
> +	[MIPI_SEQ_BACKLIGHT_OFF] = "MIPI_SEQ_BACKLIGHT_OFF",
> +	[MIPI_SEQ_TEAR_ON] = "MIPI_SEQ_TEAR_ON",
> +	[MIPI_SEQ_TEAR_OFF] = "MIPI_SEQ_TEAR_OFF",
> +	[MIPI_SEQ_POWER_ON] = "MIPI_SEQ_POWER_ON",
> +	[MIPI_SEQ_POWER_OFF] = "MIPI_SEQ_POWER_OFF",
>  };

Could avoid a bit of typing/potential typos with some preprocessor tricks.

But anyways
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  
>  static const char *sequence_name(enum mipi_seq seq_id)
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx