From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 09/10] virtio: read avail_idx from VQ only when necessary
Date: Wed, 20 Jan 2016 18:32:30 +0100 [thread overview]
Message-ID: <20160120183230.59fbaf94.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <569E850A.5070300@redhat.com>
On Tue, 19 Jan 2016 19:48:42 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> >> @@ -1579,6 +1595,7 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f, int version_id)
> >> return -1;
> >> }
> >> vdev->vq[i].used_idx = vring_used_idx(&vdev->vq[i]);
> >> + vdev->vq[i].shadow_avail_idx = vring_avail_idx(&vdev->vq[i]);
> >> }
> >> }
> >
> >
> > shadow_avail_idx also should be updated on vhost stop,
>
> That's virtio_queue_set_last_avail_idx, right?
That should also take care of vring teardown.
next prev parent reply other threads:[~2016-01-20 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 12:41 [Qemu-devel] [PATCH 00/10] virtio/vring: optimization patches Paolo Bonzini
2016-01-15 12:41 ` [Qemu-devel] [PATCH 01/10] virtio: move VirtQueueElement at the beginning of the structs Paolo Bonzini
2016-01-19 12:09 ` Cornelia Huck
2016-01-19 13:22 ` Paolo Bonzini
2016-01-19 14:01 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 02/10] virtio: move allocation to virtqueue_pop/vring_pop Paolo Bonzini
2016-01-19 12:22 ` Cornelia Huck
2016-01-19 13:16 ` Paolo Bonzini
2016-01-15 12:41 ` [Qemu-devel] [PATCH 03/10] virtio: introduce qemu_get/put_virtqueue_element Paolo Bonzini
2016-01-19 12:30 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 04/10] virtio: introduce virtqueue_alloc_element Paolo Bonzini
2016-01-19 12:40 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 05/10] virtio: slim down allocation of VirtQueueElements Paolo Bonzini
2016-01-19 15:54 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 06/10] vring: " Paolo Bonzini
2016-01-19 15:58 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor Paolo Bonzini
2016-01-19 16:07 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 08/10] virtio: cache used_idx in a VirtQueue field Paolo Bonzini
2016-01-19 16:11 ` Cornelia Huck
2016-01-15 12:41 ` [Qemu-devel] [PATCH 09/10] virtio: read avail_idx from VQ only when necessary Paolo Bonzini
2016-01-19 16:20 ` Cornelia Huck
2016-01-19 16:54 ` Michael S. Tsirkin
2016-01-19 18:48 ` Paolo Bonzini
2016-01-20 17:32 ` Cornelia Huck [this message]
2016-01-21 21:40 ` Vincenzo Maffione
2016-01-15 12:41 ` [Qemu-devel] [PATCH 10/10] virtio: combine write of an entry into used ring Paolo Bonzini
2016-01-19 16:26 ` Cornelia Huck
2016-01-31 10:28 [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches Paolo Bonzini
2016-01-31 10:29 ` [Qemu-devel] [PATCH 09/10] virtio: read avail_idx from VQ only when necessary Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120183230.59fbaf94.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.