On Mon, Jan 25, 2016 at 11:59:22AM +0000, Peter Maydell wrote:
> On 25 January 2016 at 11:19, David Gibson <david@gibson.dropbear.id.au> wrote:
> > I think I've fixed it, but it's a bit hard to tell since for me
> > origin/master also fails to compile on 32-bit :(.
> 
> Oops -- what's the failure there?
> 
> (I do know of a vixl compile failure with older gcc you might be running
> into; if that's it try configuring with --cxx=none. I should send a patch
> to fix that.)

Doesn't look like it.  Might be something to do with a specific glib
version though:

$ make -k
  CC    qga/commands-posix.o
qga/commands-posix.c: In function ‘qmp_guest_file_write’:
qga/commands-posix.c:529:39: error: passing argument 3 of ‘qbase64_decode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     buf = qbase64_decode(buf_b64, -1, &buf_len, errp);
                                       ^
In file included from qga/commands-posix.c:32:0:
/home/dwg/src/qemu/include/qemu/base64.h:52:10: note: expected ‘size_t * {aka unsigned int *}’ but argument is of type ‘gsize * {aka long unsigned int *}’
 uint8_t *qbase64_decode(const char *input,
          ^
cc1: all warnings being treated as errors
/home/dwg/src/qemu/rules.mak:57: recipe for target 'qga/commands-posix.o' failed
make: *** [qga/commands-posix.o] Error 1
  CC    util/base64.o
util/base64.c: In function ‘qbase64_decode’:
util/base64.c:59:35: error: passing argument 2 of ‘g_base64_decode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     return g_base64_decode(input, out_len);
                                   ^
In file included from /usr/include/glib-2.0/glib.h:35:0,
                 from /home/dwg/src/qemu/include/glib-compat.h:19,
                 from /home/dwg/src/qemu/include/qemu/osdep.h:72,
                 from /home/dwg/src/qemu/include/qemu-common.h:15,
                 from /home/dwg/src/qemu/include/qemu/base64.h:24,
                 from util/base64.c:23:
/usr/include/glib-2.0/glib/gbase64.h:52:9: note: expected ‘gsize * {aka long unsigned int *}’ but argument is of type ‘size_t * {aka unsigned int *}’
 guchar *g_base64_decode         (const gchar  *text,
         ^
cc1: all warnings being treated as errors
/home/dwg/src/qemu/rules.mak:57: recipe for target 'util/base64.o' failed
make: *** [util/base64.o] Error 1
  CC    crypto/secret.o
crypto/secret.c: In function ‘qcrypto_secret_load_data’:
crypto/secret.c:47:55: error: passing argument 3 of ‘g_file_get_contents’ from incompatible pointer type [-Werror=incompatible-pointer-types]
         if (!g_file_get_contents(secret->file, &data, &length, &gerr)) {
                                                       ^
In file included from /usr/include/glib-2.0/glib.h:48:0,
                 from /home/dwg/src/qemu/include/glib-compat.h:19,
                 from /home/dwg/src/qemu/include/qemu/osdep.h:72,
                 from /home/dwg/src/qemu/include/qemu-common.h:15,
                 from /home/dwg/src/qemu/include/crypto/secret.h:24,
                 from crypto/secret.c:21:
/usr/include/glib-2.0/glib/gfileutils.h:85:10: note: expected ‘gsize * {aka long unsigned int *}’ but argument is of type ‘size_t * {aka unsigned int *}’
 gboolean g_file_get_contents (const gchar  *filename,
          ^
cc1: all warnings being treated as errors
/home/dwg/src/qemu/rules.mak:57: recipe for target 'crypto/secret.o' failed
make: *** [crypto/secret.o] Error 1
  CC    qemu-char.o
qemu-char.c: In function ‘qmp_ringbuf_write’:
qemu-char.c:3317:37: error: passing argument 3 of ‘qbase64_decode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
                                     &write_count,
                                     ^
In file included from qemu-char.c:35:0:
/home/dwg/src/qemu/include/qemu/base64.h:52:10: note: expected ‘size_t * {aka unsigned int *}’ but argument is of type ‘gsize * {aka long unsigned int *}’
 uint8_t *qbase64_decode(const char *input,
          ^
cc1: all warnings being treated as errors
/home/dwg/src/qemu/rules.mak:57: recipe for target 'qemu-char.o' failed
make: *** [qemu-char.o] Error 1
  CC    vl.o
vl.c: In function ‘parse_fw_cfg’:
vl.c:2317:46: error: passing argument 3 of ‘g_file_get_contents’ from incompatible pointer type [-Werror=incompatible-pointer-types]
         if (!g_file_get_contents(file, &buf, &size, NULL)) {
                                              ^
In file included from /usr/include/glib-2.0/glib.h:48:0,
                 from vl.c:59:
/usr/include/glib-2.0/glib/gfileutils.h:85:10: note: expected ‘gsize * {aka long unsigned int *}’ but argument is of type ‘size_t * {aka unsigned int *}’
 gboolean g_file_get_contents (const gchar  *filename,
          ^
cc1: all warnings being treated as errors
/home/dwg/src/qemu/rules.mak:57: recipe for target 'vl.o' failed
make: *** [vl.o] Error 1
make: Target 'all' not remade because of errors.


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson