From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Nikolay Aleksandrov <razor@blackwall.org>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
davem@davemloft.net,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions
Date: Thu, 4 Feb 2016 14:18:36 +0200 [thread overview]
Message-ID: <20160204121836.GA5864@redhat.com> (raw)
In-Reply-To: <20160204103226.333d98ca@samsung9>
On Thu, Feb 04, 2016 at 10:32:26AM +1100, Stephen Hemminger wrote:
> On Wed, 3 Feb 2016 04:04:36 +0100
> Nikolay Aleksandrov <razor@blackwall.org> wrote:
>
> >
> > +static inline int ethtool_validate_speed(__u32 speed)
> > +{
>
>
> No need for inline.
>
> But why check for valid value at all. At some point in the
> future, there will be yet another speed adopted by some standard body
> and the switch statement would need another value.
>
> Why not accept any value? This is a virtual device.
It's virtual but often there's a physical backend behind it. In the
future we will likely forward the values to and from that physical
device. And if guest passes an unexpected value, host is unlikely to be
able to support it.
--
MST
next prev parent reply other threads:[~2016-02-04 12:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 3:04 [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support Nikolay Aleksandrov
2016-02-03 3:04 ` [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions Nikolay Aleksandrov
2016-02-03 23:32 ` Stephen Hemminger
2016-02-03 23:49 ` Rick Jones
2016-02-04 12:47 ` Michael S. Tsirkin
2016-02-04 17:30 ` Rick Jones
2016-02-04 11:02 ` Nikolay Aleksandrov
2016-02-04 12:18 ` Michael S. Tsirkin [this message]
2016-02-03 3:04 ` [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings Nikolay Aleksandrov
2016-02-03 9:19 ` Nikolay Aleksandrov
2016-02-04 12:23 ` Michael S. Tsirkin
2016-02-04 12:21 ` Michael S. Tsirkin
2016-02-04 12:26 ` Nikolay Aleksandrov
2016-02-07 19:31 ` [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support David Miller
2016-02-07 19:35 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204121836.GA5864@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.