From: Daniel Vetter <daniel@ffwll.ch>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, Haixia Shi <hshi@chromium.org>
Subject: Re: [PATCH 1/2] drm/msm: remove the drm_device_is_unplugged check
Date: Tue, 9 Feb 2016 14:03:28 +0100 [thread overview]
Message-ID: <20160209130328.GV11240@phenom.ffwll.local> (raw)
In-Reply-To: <CANq1E4S+MNVq_Ws1QjADTD+HJKwKfuKmN=LA9JaoQy1XZCA-pQ@mail.gmail.com>
On Tue, Feb 09, 2016 at 11:25:27AM +0100, David Herrmann wrote:
> Hi
>
> On Fri, Feb 5, 2016 at 10:57 PM, Haixia Shi <hshi@chromium.org> wrote:
> > This flag is only used for drm/udl.
>
> Furthermore, it is horribly racy. Lets not make use of it outside of udl.
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Applied to drm-misc (assuming that 2/2 will go in there too).
-Daniel
>
> Thanks
> David
>
> > Signed-off-by: Haixia Shi <hshi@chromium.org>
> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> > ---
> > drivers/gpu/drm/msm/msm_fbdev.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> > index d95af6e..e119c29 100644
> > --- a/drivers/gpu/drm/msm/msm_fbdev.c
> > +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> > @@ -65,9 +65,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
> > struct drm_device *dev = helper->dev;
> > int ret = 0;
> >
> > - if (drm_device_is_unplugged(dev))
> > - return -ENODEV;
> > -
> > ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
> > if (ret) {
> > pr_err("%s:drm_gem_mmap_obj fail\n", __func__);
> > --
> > 2.7.0.rc3.207.g0ac5344
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-09 13:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 21:57 [PATCH 1/2] drm/msm: remove the drm_device_is_unplugged check Haixia Shi
2016-02-05 21:57 ` [PATCH 2/2] drm: make unplugged flag specific to udl driver Haixia Shi
2016-02-09 12:44 ` David Herrmann
2016-02-09 20:45 ` Haixia Shi
2016-02-09 20:52 ` David Herrmann
2016-02-10 23:16 ` [PATCH v2 2/2] drm: remove drm_device_is_unplugged checks in common drm code Haixia Shi
2016-02-09 10:25 ` [PATCH 1/2] drm/msm: remove the drm_device_is_unplugged check David Herrmann
2016-02-09 13:03 ` Daniel Vetter [this message]
2016-02-09 21:05 ` [PATCH 2/2] drm: make unplugged flag specific to udl driver Haixia Shi
2016-02-10 6:27 ` Daniel Vetter
2016-02-10 12:24 ` David Herrmann
2016-02-10 20:39 ` Haixia Shi
2016-02-10 21:38 ` David Herrmann
2016-02-10 21:46 ` Stéphane Marchesin
2016-02-10 21:54 ` David Herrmann
2016-02-10 22:02 ` Stéphane Marchesin
2016-02-10 22:09 ` David Herrmann
2016-02-11 8:17 ` Daniel Vetter
2016-02-10 20:51 ` Haixia Shi
2016-02-10 21:00 ` Haixia Shi
2016-02-10 21:33 ` David Herrmann
2016-02-10 21:35 ` David Herrmann
2016-02-10 21:38 ` Haixia Shi
2016-02-10 21:40 ` David Herrmann
2016-02-10 23:18 ` [PATCH v2 2/2] drm: remove drm_device_is_unplugged checks in common drm code Haixia Shi
2016-02-11 8:19 ` Daniel Vetter
2016-02-11 10:30 ` David Herrmann
2016-02-11 19:19 ` Haixia Shi
2016-02-11 21:57 ` [PATCH v3 2/2] drm: remove drm_device_is_unplugged and related code Haixia Shi
2016-02-12 6:22 ` Daniel Vetter
2016-02-12 19:50 ` Haixia Shi
2016-02-17 0:27 ` Haixia Shi
2016-02-26 14:29 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209130328.GV11240@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hshi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.