From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbcB2R60 (ORCPT ); Mon, 29 Feb 2016 12:58:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcB2R6Y (ORCPT ); Mon, 29 Feb 2016 12:58:24 -0500 Date: Mon, 29 Feb 2016 18:58:17 +0100 From: Oleg Nesterov To: Michal Hocko Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Peter Zijlstra , Petr Cermak , Thomas Gleixner Subject: Re: [PATCH 07/18] mm, proc: make clear_refs killable Message-ID: <20160229175816.GE3615@redhat.com> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-8-git-send-email-mhocko@kernel.org> <20160229173845.GC3615@redhat.com> <20160229175338.GM16930@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229175338.GM16930@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 29 Feb 2016 17:58:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29, Michal Hocko wrote: > > On Mon 29-02-16 18:38:45, Oleg Nesterov wrote: > > > In this case you do not need put_task_struct(). > > Why not? Both are after get_proc_task which takes a reference to the > task... Yes, but we already have put_task_struct(task) in the "out_mm" path, so "goto out_mm" should work just fine? Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH 07/18] mm, proc: make clear_refs killable Date: Mon, 29 Feb 2016 18:58:17 +0100 Message-ID: <20160229175816.GE3615@redhat.com> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-8-git-send-email-mhocko@kernel.org> <20160229173845.GC3615@redhat.com> <20160229175338.GM16930@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcB2R6Y (ORCPT ); Mon, 29 Feb 2016 12:58:24 -0500 Content-Disposition: inline In-Reply-To: <20160229175338.GM16930@dhcp22.suse.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Hocko Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Peter Zijlstra On 02/29, Michal Hocko wrote: > > On Mon 29-02-16 18:38:45, Oleg Nesterov wrote: > > > In this case you do not need put_task_struct(). > > Why not? Both are after get_proc_task which takes a reference to the > task... Yes, but we already have put_task_struct(task) in the "out_mm" path, so "goto out_mm" should work just fine? Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by kanga.kvack.org (Postfix) with ESMTP id 316F6828E1 for ; Mon, 29 Feb 2016 12:58:25 -0500 (EST) Received: by mail-qk0-f179.google.com with SMTP id s5so59367566qkd.0 for ; Mon, 29 Feb 2016 09:58:25 -0800 (PST) Date: Mon, 29 Feb 2016 18:58:17 +0100 From: Oleg Nesterov Subject: Re: [PATCH 07/18] mm, proc: make clear_refs killable Message-ID: <20160229175816.GE3615@redhat.com> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-8-git-send-email-mhocko@kernel.org> <20160229173845.GC3615@redhat.com> <20160229175338.GM16930@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229175338.GM16930@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Peter Zijlstra , Petr Cermak , Thomas Gleixner On 02/29, Michal Hocko wrote: > > On Mon 29-02-16 18:38:45, Oleg Nesterov wrote: > > > In this case you do not need put_task_struct(). > > Why not? Both are after get_proc_task which takes a reference to the > task... Yes, but we already have put_task_struct(task) in the "out_mm" path, so "goto out_mm" should work just fine? Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org