On Sat, Feb 06, 2016 at 11:44:25AM -0700, Sagar Dharia wrote: > @@ -253,6 +276,7 @@ static int msm_xfer_msg(struct slim_controller *ctrl, struct slim_msg_txn *txn, > if (txn->msg && txn->msg->wbuf) > memcpy(puc, txn->msg->wbuf, txn->msg->num_bytes); > > + > return msm_slim_queue_tx(dev, head, txn->rl, MGR_TX_MSG); > } > This change for some reason seems to have a few of these random whitespace only changes here. > + ret = slim_ctrl_clk_pause(&dev->ctrl, false, SLIM_CLK_UNSPECIFIED); > + if (ret) > + dev_err(device, "clk pause not entered:%d", ret); > + else { > + clk_disable_unprepare(dev->hclk); > + clk_disable_unprepare(dev->rclk); > + } > + return ret; Coding style, {} should be on both sides. It's also a bit odd that we don't ever reenable these clocks.